From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 2/6] drm/i915/dpt: Only do the POT stride remap when using DPT
Date: Mon, 20 Mar 2023 11:05:18 +0200 [thread overview]
Message-ID: <20230320090522.9909-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20230320090522.9909-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
If we want to test with DPT disabled on ADL the POT stride remap
stuff needs to be disabled. Make it depend on actual DPT usage
instead of just assuming it based on the modifier.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 799bdc81a6a9..26ad5fc0c2c1 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -1189,7 +1189,7 @@ bool intel_fb_needs_pot_stride_remap(const struct intel_framebuffer *fb)
{
struct drm_i915_private *i915 = to_i915(fb->base.dev);
- return IS_ALDERLAKE_P(i915) && fb->base.modifier != DRM_FORMAT_MOD_LINEAR;
+ return IS_ALDERLAKE_P(i915) && intel_fb_uses_dpt(&fb->base);
}
static int intel_fb_pitch(const struct intel_framebuffer *fb, int color_plane, unsigned int rotation)
--
2.39.2
next prev parent reply other threads:[~2023-03-20 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:05 [Intel-gfx] [PATCH 0/6] drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam Ville Syrjala
2023-03-20 9:05 ` [PATCH 1/6] drm/i915/dpt: Treat the DPT BO as a framebuffer Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] " Ville Syrjala
2023-03-20 9:46 ` Matthew Auld
2023-03-20 9:46 ` [Intel-gfx] " Matthew Auld
2023-03-20 9:05 ` Ville Syrjala [this message]
2023-03-20 9:05 ` [Intel-gfx] [PATCH 3/6] drm/i915/dpt: Introduce HAS_DPT() Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 4/6] drm/i915: Add PLANE_CHICKEN registers Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 5/6] drm/i915/dpt: Add a modparam to disable DPT via the chicken bit Ville Syrjala
2023-03-20 9:05 ` [Intel-gfx] [PATCH 6/6] drm/i915: Move PLANE_BUG_CFG bit definitons to the correct place Ville Syrjala
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dpt: Fix DPT+shmem combo and add i915.enable_dpt modparam Patchwork
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-20 16:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-20 16:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-20 20:04 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-22 15:15 ` [Intel-gfx] [PATCH 0/6] " Juha-Pekka Heikkila
2023-03-22 16:15 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320090522.9909-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.