[PATCH 0/2] usb: host: u132-hcd: Two cleanups - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ard Biesheuvel <ardb@kernel.org>
Cc: linux-usb@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH 0/2] usb: host: u132-hcd: Two cleanups
Date: Tue, 21 Mar 2023 11:19:09 +0100	[thread overview]
Message-ID: <20230321101911.342538-1-u.kleine-koenig@pengutronix.de> (raw)

Hello,

this driver is horrifying. I made these two cleanups but there is more to do:
 - Drop the explicit kref handling (or at least only do it in one place)
 - Simplify .remove() further (I think at entry ->going should never be > 1 (or
   even > 0?) Also "u132->going++ > 1" means the device is already gone, not
   "being removed".
 - Fix .remove() not to return -ENODEV;
 - I'm sure there is more.

Uwe Kleine-König (2):
  usb: host: u132-hcd: Various style improvements
  usb: host: u132-hcd: Drop if with an always true condition

 drivers/usb/host/u132-hcd.c | 452 +++++++++++++++++++-----------------
 1 file changed, 236 insertions(+), 216 deletions(-)

base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
-- 
2.39.2