From: kernel test robot <lkp@intel.com>
To: Tanmay Shah <tanmay.shah@amd.com>,
andersson@kernel.org, mathieu.poirier@linaro.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Tanmay Shah <tanmay.shah@amd.com>,
Tarak Reddy <tarak.reddy@amd.com>
Subject: Re: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
Date: Wed, 22 Mar 2023 14:20:27 +0800 [thread overview]
Message-ID: <202303221441.cuBnpvye-lkp@intel.com> (raw)
In-Reply-To: <20230322040933.924813-3-tanmay.shah@amd.com>
Hi Tanmay,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on e19967994d342a5986d950a1bfddf19d7e1191b7]
url: https://github.com/intel-lab-lkp/linux/commits/Tanmay-Shah/remoteproc-Make-rproc_get_by_phandle-work-for-clusters/20230322-121102
base: e19967994d342a5986d950a1bfddf19d7e1191b7
patch link: https://lore.kernel.org/r/20230322040933.924813-3-tanmay.shah%40amd.com
patch subject: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
config: arm-randconfig-r013-20230322 (https://download.01.org/0day-ci/archive/20230322/202303221441.cuBnpvye-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/573d22d13a697097d02d6c29a75fb0fb1ac6d8fe
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Tanmay-Shah/remoteproc-Make-rproc_get_by_phandle-work-for-clusters/20230322-121102
git checkout 573d22d13a697097d02d6c29a75fb0fb1ac6d8fe
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/remoteproc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303221441.cuBnpvye-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/remoteproc/remoteproc_core.c:2563:26: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
struct platform_device *cluster_pdev;
^
1 warning generated.
vim +2563 drivers/remoteproc/remoteproc_core.c
2550
2551 /**
2552 * rproc_put() - release rproc reference
2553 * @rproc: the remote processor handle
2554 *
2555 * This function decrements the rproc dev refcount.
2556 *
2557 * If no one holds any reference to rproc anymore, then its refcount would
2558 * now drop to zero, and it would be freed.
2559 */
2560 void rproc_put(struct rproc *rproc)
2561 {
2562 module_put(rproc->dev.parent->driver->owner);
> 2563 struct platform_device *cluster_pdev;
2564
2565 if (rproc->dev.parent) {
2566 if (rproc->dev.parent->driver) {
2567 module_put(rproc->dev.parent->driver->owner);
2568 } else {
2569 cluster_pdev = of_find_device_by_node(rproc->dev.parent->of_node->parent);
2570 if (cluster_pdev) {
2571 module_put(cluster_pdev->dev.driver->owner);
2572 put_device(&cluster_pdev->dev);
2573 }
2574 }
2575 }
2576 put_device(&rproc->dev);
2577 }
2578 EXPORT_SYMBOL(rproc_put);
2579
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-22 6:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 4:09 [PATCH v2 0/2] remoteproc: get rproc devices for clusters Tanmay Shah
2023-03-22 4:09 ` [PATCH v2 1/2] remoteproc: Make rproc_get_by_phandle() work " Tanmay Shah
2023-03-22 4:09 ` [PATCH v2 2/2] remoteproc: enhance rproc_put() " Tanmay Shah
2023-03-22 6:20 ` kernel test robot [this message]
2023-03-22 7:31 ` kernel test robot
2023-03-22 11:52 ` Dan Carpenter
2023-03-22 16:05 ` Mathieu Poirier
2023-03-22 17:34 ` Tanmay Shah
2023-03-23 22:45 ` Mathieu Poirier
2023-03-22 14:12 ` [PATCH v2 0/2] remoteproc: get rproc devices " Bjorn Andersson
2023-03-22 16:11 ` Mathieu Poirier
2023-03-22 17:37 ` Tanmay Shah
2023-03-22 11:28 [PATCH v2 2/2] remoteproc: enhance rproc_put() " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303221441.cuBnpvye-lkp@intel.com \
--to=lkp@intel.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mathieu.poirier@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tanmay.shah@amd.com \
--cc=tarak.reddy@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.