From: "Darrick J. Wong" <djwong@kernel.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: fstests@vger.kernel.org, Zorro Lang <zlang@redhat.com>
Subject: Re: [PATCH] m4: Check for FTW_ACTIONRETVAL along with nftw
Date: Fri, 24 Mar 2023 20:45:39 -0700 [thread overview]
Message-ID: <20230325034539.GA16209@frogsfrogsfrogs> (raw)
In-Reply-To: <20230325012858.587801-1-raj.khem@gmail.com>
On Fri, Mar 24, 2023 at 06:28:58PM -0700, Khem Raj wrote:
> FTW_ACTIONRETVAL is glibc specific extention which is used to implement
> xfsfind but it may not be available on other C library implementations on Linux
> e.g. musl. Therefore ensure that these defines are available before declaring
> nftw() to be usable
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: Zorro Lang <zlang@redhat.com>
> ---
> m4/package_libcdev.m4 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
> index b41c087b..7f731044 100644
> --- a/m4/package_libcdev.m4
> +++ b/m4/package_libcdev.m4
> @@ -132,7 +132,7 @@ AC_DEFUN([AC_HAVE_NFTW],
> #include <stddef.h>
> #include <ftw.h>
> ]], [[
> - nftw("/", (int (*)(const char *, const struct stat *, int, struct FTW *))1, 0, 0);
> + nftw("/", (int (*)(const char *, const struct stat *, int, struct FTW *))1, 0, FTW_ACTIONRETVAL);
Seems fine, though xfsfind.c only uses FTW_CONTINUE and FTW_STOP, so
perhaps it'd better to modify the program not to use FTW_ACTIONRETVAL?
OTOH I'm not /that/ keen on using fuzzing xfs from musl so I'll add this
to my backlog and in the meantime
Looks good to me,
Acked-by: Darrick J. Wong <djwong@kernel.org>
--D
> ]])],[have_nftw=yes
> AC_MSG_RESULT(yes)],[AC_MSG_RESULT(no)])
> AC_SUBST(have_nftw)
> --
> 2.40.0
>
prev parent reply other threads:[~2023-03-25 3:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 1:28 [PATCH] m4: Check for FTW_ACTIONRETVAL along with nftw Khem Raj
2023-03-25 3:45 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230325034539.GA16209@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=raj.khem@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.