From: Luis Chamberlain <mcgrof@kernel.org>
To: david@redhat.com, patches@lists.linux.dev,
linux-modules@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, pmladek@suse.com,
petr.pavlu@suse.com, prarit@redhat.com,
torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
rafael@kernel.org
Cc: christophe.leroy@csgroup.eu, tglx@linutronix.de,
peterz@infradead.org, song@kernel.org, rppt@kernel.org,
dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz,
mhocko@suse.com, dave.hansen@linux.intel.com,
colin.i.king@gmail.com, jim.cromie@gmail.com,
catalin.marinas@arm.com, jbaron@akamai.com,
rick.p.edgecombe@intel.com, mcgrof@kernel.org
Subject: [PATCH v2 0/6] module: avoid userspace pressure on unwanted allocations
Date: Tue, 4 Apr 2023 19:26:56 -0700 [thread overview]
Message-ID: <20230405022702.753323-1-mcgrof@kernel.org> (raw)
This v2 series follows up on the first iteration of these patches [0].
They have the following changes made:
o Rolled in fix for an kmemleak issue reported by Jim Cromie
o Dropped from this series all the semaphore & and simplifications
on kmod.c as that should just be sent as a separate bike-shedding
opporunity patch series and it does not in any way address the
the unwanted allocations.
o The rest of the feedback was just from Greg KH and I've addressed
all his feedback. I decided to do away with the debug.c as a
separate file and leave the #ifdef CONFIG_MODULE_DEBUG eyesore
at the end of main.c. I guess it's not so bad there.
o *Tons* of fixes and enhancements to my counters, including tons
of documentation to help ensure we don't loose track of some of
the tribal knowledge and so to help ensure we have references to
what our accounting looks like. Those large wasted virtual memory
allocations on a simple qemu idle boring boot are simply rediculous, I
am quite baffled we had not spotted this before, and so it all reveals
we have quite a bit of optimizations left to do to make loading modules
an even more smoother experience at bootup.
If you'd like a tree this is on my 20230404-module-alloc-opts branch based
on modules-next [1].
[0] https://lkml.kernel.org/r/20230329053149.3976378-1-mcgrof@kernel.org
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230404-module-alloc-opts
Luis Chamberlain (6):
module: fix kmemleak annotations for non init ELF sections
module: move finished_loading()
module: extract patient module check into helper
module: avoid allocation if module is already present and ready
debugfs: add debugfs_create_atomic64_t for atomic64_t
module: add debug stats to help identify memory pressure
Documentation/core-api/kernel-api.rst | 22 +-
fs/debugfs/file.c | 36 +++
include/linux/debugfs.h | 2 +
kernel/module/Kconfig | 37 +++
kernel/module/Makefile | 1 +
kernel/module/decompress.c | 4 +
kernel/module/internal.h | 74 +++++
kernel/module/main.c | 198 ++++++++----
kernel/module/stats.c | 428 ++++++++++++++++++++++++++
kernel/module/tracking.c | 7 +-
10 files changed, 742 insertions(+), 67 deletions(-)
create mode 100644 kernel/module/stats.c
--
2.39.2
next reply other threads:[~2023-04-05 2:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 2:26 Luis Chamberlain [this message]
2023-04-05 2:26 ` [PATCH v2 1/6] module: fix kmemleak annotations for non init ELF sections Luis Chamberlain
2023-04-05 6:52 ` Song Liu
2023-04-11 15:17 ` Catalin Marinas
2023-04-11 17:06 ` Luis Chamberlain
2023-04-05 2:26 ` [PATCH v2 2/6] module: move finished_loading() Luis Chamberlain
2023-04-05 17:06 ` David Hildenbrand
2023-04-05 19:55 ` Luis Chamberlain
2023-04-05 2:26 ` [PATCH v2 3/6] module: extract patient module check into helper Luis Chamberlain
2023-04-05 17:11 ` David Hildenbrand
2023-04-05 19:45 ` Luis Chamberlain
2023-04-05 2:27 ` [PATCH v2 4/6] module: avoid allocation if module is already present and ready Luis Chamberlain
2023-04-05 2:27 ` [PATCH v2 5/6] debugfs: add debugfs_create_atomic64_t for atomic64_t Luis Chamberlain
2023-04-05 15:26 ` Linus Torvalds
2023-04-05 16:04 ` Luis Chamberlain
2023-04-05 16:11 ` Luis Chamberlain
2023-04-05 16:23 ` Linus Torvalds
2023-04-05 16:53 ` Luis Chamberlain
2023-04-06 8:15 ` David Laight
2023-04-06 13:38 ` Christophe Leroy
2023-04-06 13:48 ` David Laight
2023-04-06 14:14 ` David Hildenbrand
2023-04-05 2:27 ` [PATCH v2 6/6] module: add debug stats to help identify memory pressure Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405022702.753323-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=colin.i.king@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=petr.pavlu@suse.com \
--cc=pmladek@suse.com \
--cc=prarit@redhat.com \
--cc=rafael@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.