[PATCH v1 0/2] git config tests for "'git config ignores pairs ..."

From: Andrei Rybak <rybak.a.v@gmail.com>
To: git@vger.kernel.org
Cc: "Patrick Steinhardt" <ps@pks.im>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Øystein Walle" <oystwa@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH v1 0/2] git config tests for "'git config ignores pairs ..."
Date: Fri, 14 Apr 2023 10:13:50 +0200	[thread overview]
Message-ID: <20230414081352.810296-1-rybak.a.v@gmail.com> (raw)
In-Reply-To: <7a5de047-3535-3b87-f023-43c400d57131@gmail.com>

On 2023-04-06T23:35, Andrei Rybak wrote:
> There are some tests in t/t1300-config.sh that do check that standard
> output
> or standard error is empty.  And I think I stumbled some other broken
> tests,
> while checking those.
>
> Test 'git config ignores pairs without count' checks that standard error
> (2>error) is empty.  Just below it, there seems to be a copy-paste error:
> there are two tests titled 'git config ignores pairs with zero count'.
> First one doesn't check any output, but the second checks standard output,
> while calling the file "error" (>error). Test 'git config ignores pairs
> with empty count' checks >error as well.
>
> They were all introduced in d8d77153ea (config: allow specifying config
> entries
> via envvar pairs, 2021-01-12) by Patrick Steinhardt.  Patrick, what do
> you think?

Here are patches to fix these.

Andrei Rybak (2):
  t1300: drop duplicate test
  t1300: check stderr for "ignores pairs" tests

 t/t1300-config.sh | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

-- 
2.40.0