From: gregory.greenman@intel.com
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>
Subject: [PATCH 02/11] wifi: iwlwifi: fw: fix memory leak in debugfs
Date: Tue, 18 Apr 2023 12:28:05 +0300 [thread overview]
Message-ID: <20230418122405.239e501b3b8d.I4268f87809ef91209cbcd748eee0863195e70fa2@changeid> (raw)
In-Reply-To: <20230418092814.1438734-1-gregory.greenman@intel.com>
From: Johannes Berg <johannes.berg@intel.com>
Fix a memory leak that occurs when reading the fw_info
file all the way, since we return NULL indicating no
more data, but don't free the status tracking object.
Fixes: 36dfe9ac6e8b ("iwlwifi: dump api version in yaml format")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
---
drivers/net/wireless/intel/iwlwifi/fw/debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c b/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c
index 43e997283db0..607e07ed2477 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c
@@ -317,8 +317,10 @@ static void *iwl_dbgfs_fw_info_seq_next(struct seq_file *seq,
const struct iwl_fw *fw = priv->fwrt->fw;
*pos = ++state->pos;
- if (*pos >= fw->ucode_capa.n_cmd_versions)
+ if (*pos >= fw->ucode_capa.n_cmd_versions) {
+ kfree(state);
return NULL;
+ }
return state;
}
--
2.38.1
next prev parent reply other threads:[~2023-04-18 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 9:28 [PATCH 00/11] wifi: iwlwifi: updates intended for v6.4 2023-04-18 gregory.greenman
2023-04-18 9:28 ` [PATCH 01/11] wifi: iwlwifi: Update support for b0 version gregory.greenman
2023-04-18 9:28 ` gregory.greenman [this message]
2023-04-18 9:28 ` [PATCH 03/11] wifi: iwlwifi: mvm: fix MIC removal confusion gregory.greenman
2023-04-18 9:28 ` [PATCH 04/11] wifi: iwlwifi: fw: fix argument to efi.get_variable gregory.greenman
2023-04-18 9:28 ` [PATCH 05/11] wifi: iwlwifi: mvm: fix potential memory leak gregory.greenman
2023-04-18 9:28 ` [PATCH 06/11] wifi: iwlwifi: mvm: prefer RCU_INIT_POINTER() gregory.greenman
2023-04-18 9:28 ` [PATCH 07/11] wifi: iwlwifi: mvm: enable support for MLO APIs gregory.greenman
2023-04-18 9:28 ` [PATCH 08/11] wifi: iwlwifi: modify scan request and results when in link protection gregory.greenman
2023-04-18 9:28 ` [PATCH 09/11] wifi: iwlwifi: mei: make mei filtered scan more aggressive gregory.greenman
2023-04-18 9:28 ` [PATCH 10/11] wifi: iwlwifi: mei: re-ask for ownership after it was taken by CSME gregory.greenman
2023-04-18 9:28 ` [PATCH 11/11] wifi: iwlwifi: mvm: fix RFKILL report when driver is going down gregory.greenman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418122405.239e501b3b8d.I4268f87809ef91209cbcd748eee0863195e70fa2@changeid \
--to=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.