All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: tsbogend@alpha.franken.de
Cc: ndesaulniers@google.com, linux-mips@vger.kernel.org,
	 linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	patches@lists.linux.dev,
	 Naresh Kamboju <naresh.kamboju@linaro.org>,
	 Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH v2 0/2] MIPS: Fix check_bugs() modpost warning
Date: Fri, 21 Apr 2023 09:11:25 -0700	[thread overview]
Message-ID: <20230419-mips-check_bugs-init-attribute-v2-0-60a7ee65d4bf@kernel.org> (raw)

Hi all,

This series fixes a modpost warning visible in -next from check_bugs()
and helps avoid a potential, albeit unlikely, warning from
check_bugs_early().

---
Changes in v2:
- Now two separate patches: one to avoid current check_bugs() warning
  and one to avoid potential check_bugs_early() warning.
- Sink body of check_bugs_early() into setup_arch() directly, rather
  than marking it as __init (Nick).
- Add Naresh's reported-by to patch 1, which came after v1 was sent.
- Reword commit messages to note that there is not a problem at run time
  because check_bugs() and check_bugs_early(), while not marked __init,
  are only called from __init functions; modpost does not know this
  though, hence the warning.
- Link to v1: https://lore.kernel.org/r/20230419-mips-check_bugs-init-attribute-v1-1-91e6eed55b89@kernel.org

---
Nathan Chancellor (2):
      MIPS: Mark check_bugs() as __init
      MIPS: Sink body of check_bugs_early() into its only call site

 arch/mips/include/asm/bugs.h | 8 +-------
 arch/mips/kernel/setup.c     | 3 ++-
 2 files changed, 3 insertions(+), 8 deletions(-)
---
base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026
change-id: 20230419-mips-check_bugs-init-attribute-026103bdb255

Best regards,
-- 
Nathan Chancellor <nathan@kernel.org>


             reply	other threads:[~2023-04-21 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 16:11 Nathan Chancellor [this message]
2023-04-21 16:11 ` [PATCH v2 1/2] MIPS: Mark check_bugs() as __init Nathan Chancellor
2023-04-21 16:11 ` [PATCH v2 2/2] MIPS: Sink body of check_bugs_early() into its only call site Nathan Chancellor
2023-04-22 21:30 ` [PATCH v2 0/2] MIPS: Fix check_bugs() modpost warning Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419-mips-check_bugs-init-attribute-v2-0-60a7ee65d4bf@kernel.org \
    --to=nathan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=naresh.kamboju@linaro.org \
    --cc=ndesaulniers@google.com \
    --cc=patches@lists.linux.dev \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.