All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
	Amarula patchwork <linux-amarula@amarulasolutions.com>,
	michael@amarulasolutions.com,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] can: bxcan: add support for single peripheral configuration
Date: Mon, 24 Apr 2023 12:06:28 +0200	[thread overview]
Message-ID: <20230424-fracture-going-5dcaf06a9e6c-mkl@pengutronix.de> (raw)
In-Reply-To: <CABGWkvqA2hwgfGvVWS08Qu-2ZUbwc82ynhvq8-FqFuhHoV-vhw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On 24.04.2023 08:56:03, Dario Binacchi wrote:
> > This probably works. Can we do better, i.e. without this additional code?
> >
> > If you add a syscon node for the single instance CAN, too, you don't
> > need a code change here, right?
> 
> I think so.
> 
> I have only one doubt about it. This implementation allows,
> implicitly, to distinguish if the peripheral is in single
> configuration (without handle to the gcan node) or in double
> configuration (with handle to the gcan node). For example, in single
> configuration the peripheral has 14 filter banks, while in double
> configuration there are 26 shared banks. Without code changes, this
> kind of information is lost. Is it better then, for future
> developments, to add a new boolean property to the can node of the dts
> (e.g. single-conf)?

The DT ist not yet mainline, so we can still change it. Another option
is to have "st,can-primary" and "st,can-secondary" for the shared
peripherals and nothing for the single instance.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-04-24 10:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-23 17:25 [PATCH 0/4] can: bxcan: add support for single peripheral configuration Dario Binacchi
2023-04-23 17:25 ` Dario Binacchi
2023-04-23 17:25 ` [PATCH 1/4] dt-bindings: mfd: stm32f7: add binding definition for CAN3 Dario Binacchi
2023-04-23 17:25   ` Dario Binacchi
2023-04-24  9:02   ` Lee Jones
2023-04-24  9:02     ` Lee Jones
2023-05-17 14:16     ` Marc Kleine-Budde
2023-05-17 14:16       ` Marc Kleine-Budde
2023-05-17 15:23       ` Krzysztof Kozlowski
2023-05-17 15:23         ` Krzysztof Kozlowski
2023-05-17 18:21         ` Marc Kleine-Budde
2023-05-17 18:21           ` Marc Kleine-Budde
2023-04-23 17:25 ` [PATCH 2/4] ARM: dts: stm32: add CAN support on stm32f746 Dario Binacchi
2023-04-23 17:25   ` Dario Binacchi
2023-04-23 17:25 ` [PATCH 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f7 Dario Binacchi
2023-04-23 17:25   ` Dario Binacchi
2023-04-23 17:25 ` [PATCH 4/4] can: bxcan: add support for single peripheral configuration Dario Binacchi
2023-04-23 19:16   ` Marc Kleine-Budde
2023-04-24  6:56     ` Dario Binacchi
2023-04-24 10:06       ` Marc Kleine-Budde [this message]
2023-04-25 20:10         ` Dario Binacchi
2023-04-24 13:03   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424-fracture-going-5dcaf06a9e6c-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@amarulasolutions.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.