Re: [PATCH v2 5/6] generic/531: Check for O_TMPFILE

From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
	fstests@vger.kernel.org, Eryu Guan <guan@eryu.me>,
	Marc Dionne <marc.dionne@auristor.com>,
	Jeffrey Altman <jaltman@auristor.com>,
	linux-afs@lists.infradead.org
Subject: Re: [PATCH v2 5/6] generic/531: Check for O_TMPFILE
Date: Wed, 26 Apr 2023 07:54:50 -0700	[thread overview]
Message-ID: <20230426145450.GA59209@frogsfrogsfrogs> (raw)
In-Reply-To: <20230426145149.mjsuugpgusqr6oj2@zlang-mailbox>

On Wed, Apr 26, 2023 at 10:51:49PM +0800, Zorro Lang wrote:
> On Wed, Apr 26, 2023 at 10:49:31PM +0800, Zorro Lang wrote:
> > On Mon, Apr 24, 2023 at 03:10:41PM +0100, David Howells wrote:
> > > Make generic/531 check that the filesystem under test supports O_TMPFILE
> > > before attempting to test it.
> > > 
> > > Signed-off-by: David Howells <dhowells@redhat.com>
> > > cc: linux-afs@lists.infradead.org
> > > ---
> > >  tests/generic/531 | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/tests/generic/531 b/tests/generic/531
> > > index 5e84ca97..e5f3dddd 100755
> > > --- a/tests/generic/531
> > > +++ b/tests/generic/531
> > > @@ -20,6 +20,7 @@ testfile=$TEST_DIR/$seq.txt
> > >  # real QA test starts here
> > >  _supported_fs generic
> > >  _require_scratch
> > > +_require_xfs_io_command "-T"
> > 
> > Make sense,
> > 
> > Reviewed-by: Zorro Lang <zlang@redhat.com>
> 
> Oh, generic/530 is similar with 531, why only 531 need this one?

AFS doesn't support shutdown, presumably.

(But yes, both tests should be _require-ing this.)

--D

> > 
> > >  _require_test_program "t_open_tmpfiles"
> > >  
> > >  _scratch_mkfs >> $seqres.full 2>&1
> > > 
> 