From: Jeremy Sowden <jeremy@azazel.net>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
Roberto Sassu <roberto.sassu@huawei.com>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf] selftests/bpf: fix pkg-config call building sign-file
Date: Thu, 27 Apr 2023 20:58:14 +0100 [thread overview]
Message-ID: <20230427195814.GE415348@azazel.net> (raw)
In-Reply-To: <e1bd99a4ea209277d657f7fb7ccdc26451113fc9.camel@huaweicloud.com>
[-- Attachment #1: Type: text/plain, Size: 1976 bytes --]
On 2023-04-27, at 08:52:27 +0200, Roberto Sassu wrote:
> On Wed, 2023-04-26 at 22:50 +0100, Jeremy Sowden wrote:
> > When building sign-file, the call to get the CFLAGS for libcrypto is
> > missing white-space between `pkg-config` and `--cflags`:
> >
> > $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null)
> >
> > Removing the redirection of stderr, we see:
> >
> > $ make -C tools/testing/selftests/bpf sign-file
> > make: Entering directory '[...]/tools/testing/selftests/bpf'
> > make: pkg-config--cflags: No such file or directory
> > SIGN-FILE sign-file
> > make: Leaving directory '[...]/tools/testing/selftests/bpf'
> >
> > Add the missing space.
> >
> > Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
> > Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
>
> Thanks.
>
> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
>
> Roberto
Thanks. I was having e-mail problems yesterday when I sent the original
message with the patch in it, and it didn't reach some of the
recipients. I'll send it again with your `Reviewed-by:` attached.
J.
> > ---
> > tools/testing/selftests/bpf/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> > index b677dcd0b77a..ad01c9e1ff12 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r
> >
> > $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c
> > $(call msg,SIGN-FILE,,$@)
> > - $(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \
> > + $(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \
> > $< -o $@ \
> > $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-27 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 21:50 [PATCH bpf] selftests/bpf: fix pkg-config call building sign-file Jeremy Sowden
2023-04-27 6:52 ` Roberto Sassu
2023-04-27 19:58 ` Jeremy Sowden [this message]
2023-04-27 20:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427195814.GE415348@azazel.net \
--to=jeremy@azazel.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.