Re: [PATCH RFC net-next/mm V2 1/2] page_pool: Remove workqueue in new shutdown scheme

From: kernel test robot <lkp@intel.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC net-next/mm V2 1/2] page_pool: Remove workqueue in new shutdown scheme
Date: Fri, 28 Apr 2023 05:29:57 +0800	[thread overview]
Message-ID: <202304280541.EISCnBZz-lkp@intel.com> (raw)
In-Reply-To: <168262351129.2036355.1136491155595493268.stgit@firesoul>

Hi Jesper,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on horms-ipvs/master linus/master v6.3 next-20230427]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/page_pool-Remove-workqueue-in-new-shutdown-scheme/20230428-032759
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/168262351129.2036355.1136491155595493268.stgit%40firesoul
patch subject: [PATCH RFC net-next/mm V2 1/2] page_pool: Remove workqueue in new shutdown scheme
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230428/202304280541.EISCnBZz-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d6fe37a8a681d3f95c9ac342d182e6fbeba61b72
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jesper-Dangaard-Brouer/page_pool-Remove-workqueue-in-new-shutdown-scheme/20230428-032759
        git checkout d6fe37a8a681d3f95c9ac342d182e6fbeba61b72
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304280541.EISCnBZz-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/core/page_pool.c:448:14: warning: no previous prototype for 'pp_read_hold_cnt' [-Wmissing-prototypes]
     448 | noinline u32 pp_read_hold_cnt(struct page_pool *pool)
         |              ^~~~~~~~~~~~~~~~

vim +/pp_read_hold_cnt +448 net/core/page_pool.c

   446	
   447	/* Avoid inlining code to avoid speculative fetching cacheline */
 > 448	noinline u32 pp_read_hold_cnt(struct page_pool *pool)
   449	{
   450		return READ_ONCE(pool->pages_state_hold_cnt);
   451	}
   452	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests