All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Bart Van Assche <bvanassche@acm.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v4 01/11] block: Simplify blk_req_needs_zone_write_lock()
Date: Wed,  3 May 2023 15:51:58 -0700	[thread overview]
Message-ID: <20230503225208.2439206-2-bvanassche@acm.org> (raw)
In-Reply-To: <20230503225208.2439206-1-bvanassche@acm.org>

Remove the blk_rq_is_passthrough() check because it is redundant:
blk_req_needs_zone_write_lock() also calls bdev_op_is_zoned_write()
and the latter function returns false for pass-through requests.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-zoned.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index fce9082384d6..835d9e937d4d 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -57,9 +57,6 @@ EXPORT_SYMBOL_GPL(blk_zone_cond_str);
  */
 bool blk_req_needs_zone_write_lock(struct request *rq)
 {
-	if (blk_rq_is_passthrough(rq))
-		return false;
-
 	if (!rq->q->disk->seq_zones_wlock)
 		return false;
 

  reply	other threads:[~2023-05-03 22:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 22:51 [PATCH v4 00/11] mq-deadline: Improve support for zoned block devices Bart Van Assche
2023-05-03 22:51 ` Bart Van Assche [this message]
2023-05-03 22:51 ` [PATCH v4 02/11] block: Fix the type of the second bdev_op_is_zoned_write() argument Bart Van Assche
2023-05-04  7:16   ` Johannes Thumshirn
2023-05-04  8:18   ` Pankaj Raghav
2023-05-05  5:52   ` Christoph Hellwig
2023-05-03 22:52 ` [PATCH v4 03/11] block: Introduce op_is_zoned_write() Bart Van Assche
2023-05-05  5:52   ` Christoph Hellwig
2023-05-03 22:52 ` [PATCH v4 04/11] block: Introduce blk_rq_is_seq_zoned_write() Bart Van Assche
2023-05-05  5:53   ` Christoph Hellwig
2023-05-05 21:56     ` Bart Van Assche
2023-05-03 22:52 ` [PATCH v4 05/11] block: mq-deadline: Clean up deadline_check_fifo() Bart Van Assche
2023-05-03 22:52 ` [PATCH v4 06/11] block: mq-deadline: Simplify deadline_skip_seq_writes() Bart Van Assche
2023-05-03 22:52 ` [PATCH v4 07/11] block: mq-deadline: Improve deadline_skip_seq_writes() Bart Van Assche
2023-05-03 22:52 ` [PATCH v4 08/11] block: mq-deadline: Reduce lock contention Bart Van Assche
2023-05-05  5:56   ` Christoph Hellwig
2023-05-05 16:16     ` Bart Van Assche
2023-05-03 22:52 ` [PATCH v4 09/11] block: mq-deadline: Track the dispatch position Bart Van Assche
2023-05-05  5:56   ` Christoph Hellwig
2023-05-03 22:52 ` [PATCH v4 10/11] block: mq-deadline: Handle requeued requests correctly Bart Van Assche
2023-05-05  5:57   ` Christoph Hellwig
2023-05-03 22:52 ` [PATCH v4 11/11] block: mq-deadline: Fix handling of at-head zoned writes Bart Van Assche
2023-05-05  5:57   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503225208.2439206-2-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.