From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: James@pengutronix.de, Liviu Dudau <liviu.dudau@arm.com>,
Mihail Atanassov <mihail.atanassov@arm.com>,
Brian Starkey <brian.starkey@arm.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Mali DP Maintainers <malidp@foss.arm.com>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: [PATCH 01/53] drm/komeda: Convert to platform remove callback returning void
Date: Sun, 7 May 2023 18:25:24 +0200 [thread overview]
Message-ID: <20230507162616.1368908-2-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20230507162616.1368908-1-u.kleine-koenig@pengutronix.de>
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index 28f76e07dd95..c597c362f689 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -131,10 +131,9 @@ static int komeda_platform_probe(struct platform_device *pdev)
return component_master_add_with_match(dev, &komeda_master_ops, match);
}
-static int komeda_platform_remove(struct platform_device *pdev)
+static void komeda_platform_remove(struct platform_device *pdev)
{
component_master_del(&pdev->dev, &komeda_master_ops);
- return 0;
}
static const struct of_device_id komeda_of_match[] = {
@@ -189,7 +188,7 @@ static const struct dev_pm_ops komeda_pm_ops = {
static struct platform_driver komeda_platform_driver = {
.probe = komeda_platform_probe,
- .remove = komeda_platform_remove,
+ .remove_new = komeda_platform_remove,
.driver = {
.name = "komeda",
.of_match_table = komeda_of_match,
--
2.39.2
next prev parent reply other threads:[~2023-05-07 16:26 UTC|newest]
Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 16:25 [PATCH 00/53] drm: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-07 16:25 ` [Nouveau] " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König [this message]
2023-05-10 21:50 ` [PATCH 01/53] drm/komeda: " Liviu Dudau
2023-05-07 16:25 ` [PATCH 02/53] drm/arm/hdlcd: " Uwe Kleine-König
2023-05-10 21:51 ` Liviu Dudau
2023-05-07 16:25 ` [PATCH 03/53] drm/arm/malidp: " Uwe Kleine-König
2023-05-10 21:52 ` Liviu Dudau
2023-05-07 16:25 ` [PATCH 04/53] drm/armada: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 05/53] drm/aspeed: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 06/53] drm/atmel-hlcdc: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:44 ` Sam Ravnborg
2023-05-07 16:44 ` Sam Ravnborg
2023-05-08 7:04 ` Claudiu.Beznea
2023-05-07 16:25 ` [PATCH 07/53] drm/bridge: cdns-dsi: " Uwe Kleine-König
2023-05-08 2:37 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 08/53] drm/bridge: display-connector: " Uwe Kleine-König
2023-05-08 2:46 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 09/53] drm/bridge: fsl-ldb: " Uwe Kleine-König
2023-05-08 2:45 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 10/53] drm/imx/imx8*: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-08 2:43 ` Laurent Pinchart
2023-05-08 2:43 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 11/53] drm/bridge: lvds-codec: " Uwe Kleine-König
2023-05-08 2:44 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 12/53] drm/bridge: nwl-dsi: " Uwe Kleine-König
2023-05-08 2:36 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 13/53] drm/bridge: simple-bridge: " Uwe Kleine-König
2023-05-08 2:45 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 14/53] drm/bridge: synopsys: " Uwe Kleine-König
2023-05-08 2:37 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 15/53] drm/bridge: thc63lvd1024: " Uwe Kleine-König
2023-05-08 2:44 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 16/53] drm/bridge: tfp410: " Uwe Kleine-König
2023-05-08 2:44 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 17/53] drm/etnaviv: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 18/53] drm/exynos: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-15 7:32 ` Inki Dae
2023-05-15 7:32 ` Inki Dae
2023-05-15 9:16 ` Uwe Kleine-König
2023-05-15 9:16 ` Uwe Kleine-König
2023-05-15 9:16 ` Uwe Kleine-König
2023-05-19 0:11 ` 대인기
2023-05-19 0:11 ` 대인기
2023-05-19 0:11 ` 대인기
2023-05-19 6:38 ` Uwe Kleine-König
2023-05-19 6:38 ` Uwe Kleine-König
2023-05-19 6:38 ` Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 19/53] drm/fsl-dcu: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 20/53] drm/hisilicon: " Uwe Kleine-König
2023-05-08 2:41 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 21/53] drm/imx/dcss: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 22/53] drm/imx/ipuv3: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-08 7:10 ` Philipp Zabel
2023-05-07 16:25 ` [PATCH 23/53] drm/ingenic: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 18:46 ` Paul Cercueil
2023-05-07 18:46 ` Paul Cercueil
2023-05-07 16:25 ` [PATCH 24/53] drm/kmb: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 25/53] drm/lima: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 26/53] drm/logicvc: " Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 27/53] drm/mcde: " Uwe Kleine-König
2023-05-08 6:13 ` Linus Walleij
2023-05-07 16:25 ` [PATCH 28/53] drm/mediatek: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-08 8:25 ` Matthias Brugger
2023-05-08 8:25 ` Matthias Brugger
2023-05-07 16:25 ` [PATCH 29/53] " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-08 8:26 ` Matthias Brugger
2023-05-08 8:26 ` Matthias Brugger
2023-05-07 16:25 ` [PATCH 30/53] drm/meson: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-08 19:39 ` Martin Blumenstingl
2023-05-08 19:39 ` Martin Blumenstingl
2023-05-07 16:25 ` [PATCH 31/53] drm/msm: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-20 23:56 ` Dmitry Baryshkov
2023-05-20 23:56 ` Dmitry Baryshkov
2023-05-07 16:25 ` [PATCH 32/53] drm/mxsfb: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` [Nouveau] [PATCH 33/53] drm/nouveau: " Uwe Kleine-König
2023-05-07 16:25 ` Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 34/53] drm/omap: " Uwe Kleine-König
2023-05-08 2:40 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 35/53] drm/panel: " Uwe Kleine-König
2023-05-08 2:43 ` Laurent Pinchart
2023-05-07 16:25 ` [PATCH 36/53] drm/panfrost: " Uwe Kleine-König
2023-05-10 16:05 ` Steven Price
2023-05-07 16:26 ` [PATCH 37/53] drm/rcar-du: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-08 2:42 ` Laurent Pinchart
2023-05-08 2:42 ` Laurent Pinchart
2023-05-08 13:14 ` Geert Uytterhoeven
2023-05-08 13:14 ` Geert Uytterhoeven
2023-05-07 16:26 ` [PATCH 38/53] drm/rockchip: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-08 8:24 ` Heiko Stübner
2023-05-08 8:24 ` Heiko Stübner
2023-05-07 16:26 ` [PATCH 39/53] drm/shmobile: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-08 2:40 ` Laurent Pinchart
2023-05-08 2:40 ` Laurent Pinchart
2023-05-08 13:13 ` Geert Uytterhoeven
2023-05-08 13:13 ` Geert Uytterhoeven
2023-05-07 16:26 ` [PATCH 40/53] drm/sprd: " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 41/53] drm/sti: " Uwe Kleine-König
2023-05-09 7:22 ` Alain Volmat
2023-05-07 16:26 ` [PATCH 42/53] drm/stm: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-15 13:53 ` Raphael Gallais-Pou
2023-05-15 13:53 ` Raphael Gallais-Pou
2023-05-07 16:26 ` [PATCH 43/53] drm/sun4i: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 44/53] drm/tegra: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 45/53] drm/tests: helpers: " Uwe Kleine-König
2023-05-08 22:10 ` Maíra Canal
2023-05-09 5:51 ` Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 46/53] drm/tidss: " Uwe Kleine-König
2023-05-09 8:11 ` Tomi Valkeinen
2023-05-07 16:26 ` [PATCH 47/53] drm/tilcdc: " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 48/53] drm/tiny: " Uwe Kleine-König
2023-05-08 7:03 ` Thomas Zimmermann
2023-05-08 7:28 ` Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 49/53] " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 50/53] drm/tve200: " Uwe Kleine-König
2023-05-08 6:14 ` Linus Walleij
2023-05-07 16:26 ` [PATCH 51/53] drm/v3d: " Uwe Kleine-König
2023-05-07 16:26 ` [PATCH 52/53] drm/vc4: " Uwe Kleine-König
2023-05-09 14:32 ` Dave Stevenson
2023-05-07 16:26 ` [PATCH 53/53] drm/xlnx/zynqmp_dpsub: " Uwe Kleine-König
2023-05-07 16:26 ` Uwe Kleine-König
2023-05-08 2:35 ` Laurent Pinchart
2023-05-08 2:35 ` Laurent Pinchart
2023-05-08 7:06 ` [PATCH 00/53] drm: " Thomas Zimmermann
2023-05-08 7:06 ` [Nouveau] " Thomas Zimmermann
2023-05-08 7:06 ` Thomas Zimmermann
2023-05-08 7:06 ` Thomas Zimmermann
2023-05-08 7:50 ` Uwe Kleine-König
2023-05-08 7:50 ` [Nouveau] " Uwe Kleine-König
2023-05-08 7:50 ` Uwe Kleine-König
2023-05-08 7:50 ` Uwe Kleine-König
2023-05-08 14:16 ` [PATCH 47/53] drm/tilcdc: " jyri.sarha
2023-05-15 7:50 ` [PATCH 00/53] drm: " Inki Dae
2023-05-15 7:50 ` [Nouveau] " Inki Dae
2023-05-15 7:50 ` Inki Dae
2023-05-15 7:50 ` Inki Dae
2023-05-15 9:20 ` Uwe Kleine-König
2023-05-15 9:20 ` [Nouveau] " Uwe Kleine-König
2023-05-15 9:20 ` Uwe Kleine-König
2023-05-15 9:20 ` Uwe Kleine-König
2023-06-01 15:40 ` Uwe Kleine-König
2023-06-01 15:40 ` [Nouveau] " Uwe Kleine-König
2023-06-01 15:40 ` Uwe Kleine-König
2023-06-08 16:08 ` Doug Anderson
2023-06-08 16:08 ` [Nouveau] " Doug Anderson
2023-06-08 16:08 ` Doug Anderson
2023-06-08 16:26 ` Laurent Pinchart
2023-06-08 16:26 ` [Nouveau] " Laurent Pinchart
2023-06-08 16:26 ` Laurent Pinchart
2023-06-08 16:47 ` Doug Anderson
2023-06-08 16:47 ` [Nouveau] " Doug Anderson
2023-06-08 16:47 ` Doug Anderson
2023-06-08 17:19 ` Tomi Valkeinen
2023-06-08 17:19 ` [Nouveau] " Tomi Valkeinen
2023-06-08 17:19 ` Tomi Valkeinen
2023-06-08 17:38 ` Doug Anderson
2023-06-08 17:38 ` [Nouveau] " Doug Anderson
2023-06-08 17:38 ` Doug Anderson
2023-06-17 16:12 ` patches dropped from drm-misc-next [Was: Re: [PATCH 00/53] drm: Convert to platform remove callback returning] void Uwe Kleine-König
2023-06-17 16:12 ` [Nouveau] " Uwe Kleine-König
2023-06-17 16:12 ` Uwe Kleine-König
2023-06-17 16:51 ` Chen-Yu Tsai
2023-06-17 16:51 ` [Nouveau] " Chen-Yu Tsai
2023-06-17 16:51 ` Chen-Yu Tsai
2023-06-17 17:57 ` Doug Anderson
2023-06-17 17:57 ` [Nouveau] " Doug Anderson
2023-06-17 17:57 ` Doug Anderson
2023-06-18 12:39 ` Uwe Kleine-König
2023-06-18 12:39 ` [Nouveau] " Uwe Kleine-König
2023-06-18 12:39 ` Uwe Kleine-König
2023-06-18 14:02 ` Uwe Kleine-König
2023-06-18 14:02 ` [Nouveau] " Uwe Kleine-König
2023-06-18 14:02 ` Uwe Kleine-König
2023-06-18 14:32 ` Maxime Ripard
2023-06-18 14:32 ` [Nouveau] " Maxime Ripard
2023-06-18 14:32 ` Maxime Ripard
2023-06-18 16:29 ` Uwe Kleine-König
2023-06-18 16:29 ` [Nouveau] " Uwe Kleine-König
2023-06-18 16:29 ` Uwe Kleine-König
2023-06-19 9:45 ` Maxime Ripard
2023-06-19 9:45 ` [Nouveau] " Maxime Ripard
2023-06-19 9:45 ` Maxime Ripard
2023-06-19 10:53 ` Uwe Kleine-König
2023-06-19 10:53 ` [Nouveau] " Uwe Kleine-König
2023-06-19 10:53 ` Uwe Kleine-König
2023-06-19 12:47 ` Maxime Ripard
2023-06-19 12:47 ` [Nouveau] " Maxime Ripard
2023-06-19 12:47 ` Maxime Ripard
2023-06-19 13:25 ` Geert Uytterhoeven
2023-06-19 13:25 ` [Nouveau] " Geert Uytterhoeven
2023-06-19 13:25 ` Geert Uytterhoeven
2023-06-19 14:02 ` Maxime Ripard
2023-06-19 14:02 ` [Nouveau] " Maxime Ripard
2023-06-19 14:02 ` Maxime Ripard
2023-06-19 14:20 ` Geert Uytterhoeven
2023-06-19 14:20 ` [Nouveau] " Geert Uytterhoeven
2023-06-19 14:20 ` Geert Uytterhoeven
2023-06-19 13:58 ` Uwe Kleine-König
2023-06-19 13:58 ` [Nouveau] " Uwe Kleine-König
2023-06-19 13:58 ` Uwe Kleine-König
2023-06-19 14:30 ` Jani Nikula
2023-06-19 14:52 ` Geert Uytterhoeven
2023-09-09 14:37 ` [PATCH 00/53] drm: Convert to platform remove callback returning void Javier Martinez Canillas
2023-09-09 14:37 ` Javier Martinez Canillas
2023-09-09 14:37 ` Javier Martinez Canillas
2023-09-09 14:37 ` Javier Martinez Canillas
2023-09-09 14:37 ` Javier Martinez Canillas
2023-09-09 14:37 ` [Nouveau] " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230507162616.1368908-2-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=James@pengutronix.de \
--cc=airlied@gmail.com \
--cc=brian.starkey@arm.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=liviu.dudau@arm.com \
--cc=malidp@foss.arm.com \
--cc=mihail.atanassov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.