Re: [PATCH 0/2] statfs: Enforce statfs[64] structure intialization

From: Andrew Morton <akpm@linux-foundation.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH 0/2] statfs: Enforce statfs[64] structure intialization
Date: Thu, 11 May 2023 20:45:18 -0700	[thread overview]
Message-ID: <20230511204518.eba10b4cbf9568a24d1d428b@linux-foundation.org> (raw)
In-Reply-To: <ZFz9I5bhRh2wH14i@osiris>

On Thu, 11 May 2023 16:35:15 +0200 Heiko Carstens <hca@linux.ibm.com> wrote:

> On Thu, May 04, 2023 at 04:40:19PM +0200, Ilya Leoshkevich wrote:
> > This series fixes copying of uninitialized memory to userspace by
> > do_statfs_native() and do_statfs64() on s390.
> > 
> > Patch 1 fixes the problem by making the code similar to
> > put_compat_statfs() and put_compat_statfs64().
> > 
> > Patch 2 gets rid of the padding which caused the issue; even though it
> > may be considered redundant, it documents that s390 de-facto has an
> > extra f_spare array element.
> > 
> > Ilya Leoshkevich (2):
> >   statfs: Enforce statfs[64] structure intialization
> >   s390/uapi: Cover statfs padding by growing f_spare
> > 
> >  arch/s390/include/asm/compat.h      | 2 +-
> >  arch/s390/include/uapi/asm/statfs.h | 4 ++--
> >  fs/statfs.c                         | 4 ++--
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> Al, Andrew, should this go via the s390 tree?

I'd say so.