All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	jyescas@google.com, mcgrof@kernel.org,
	Bart Van Assche <bvanassche@acm.org>,
	Ming Lei <ming.lei@redhat.com>, Keith Busch <kbusch@kernel.org>
Subject: [PATCH v5 2/9] block: Prepare for supporting sub-page limits
Date: Mon, 22 May 2023 15:25:34 -0700	[thread overview]
Message-ID: <20230522222554.525229-3-bvanassche@acm.org> (raw)
In-Reply-To: <20230522222554.525229-1-bvanassche@acm.org>

Introduce variables that represent the lower configuration bounds. This
patch does not change any functionality.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-settings.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index 1d8d2ae7bdf4..95d6e836c4a7 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -123,10 +123,11 @@ EXPORT_SYMBOL(blk_queue_bounce_limit);
 void blk_queue_max_hw_sectors(struct request_queue *q, unsigned int max_hw_sectors)
 {
 	struct queue_limits *limits = &q->limits;
+	unsigned int min_max_hw_sectors = PAGE_SIZE >> SECTOR_SHIFT;
 	unsigned int max_sectors;
 
-	if ((max_hw_sectors << 9) < PAGE_SIZE) {
-		max_hw_sectors = 1 << (PAGE_SHIFT - 9);
+	if (max_hw_sectors < min_max_hw_sectors) {
+		max_hw_sectors = min_max_hw_sectors;
 		pr_info("%s: set to minimum %u\n", __func__, max_hw_sectors);
 	}
 
@@ -281,8 +282,10 @@ EXPORT_SYMBOL_GPL(blk_queue_max_discard_segments);
  **/
 void blk_queue_max_segment_size(struct request_queue *q, unsigned int max_size)
 {
-	if (max_size < PAGE_SIZE) {
-		max_size = PAGE_SIZE;
+	unsigned int min_max_segment_size = PAGE_SIZE;
+
+	if (max_size < min_max_segment_size) {
+		max_size = min_max_segment_size;
 		pr_info("%s: set to minimum %u\n", __func__, max_size);
 	}
 

  parent reply	other threads:[~2023-05-22 22:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 22:25 [PATCH v5 0/9] Support limits below the page size Bart Van Assche
2023-05-22 22:25 ` [PATCH v5 1/9] block: Use pr_info() instead of printk(KERN_INFO ...) Bart Van Assche
2023-05-22 23:10   ` Luis Chamberlain
2023-05-27 16:09     ` Bart Van Assche
2023-05-22 22:25 ` Bart Van Assche [this message]
2023-05-22 23:26   ` [PATCH v5 2/9] block: Prepare for supporting sub-page limits Luis Chamberlain
2023-05-22 22:25 ` [PATCH v5 3/9] block: Support configuring limits below the page size Bart Van Assche
2023-05-27  3:16   ` Luis Chamberlain
2023-05-27 16:20     ` Bart Van Assche
2023-05-28 20:33       ` Luis Chamberlain
2023-05-28 22:32         ` Bart Van Assche
2023-05-31  5:40           ` Luis Chamberlain
2023-05-22 22:25 ` [PATCH v5 4/9] block: Make sub_page_limit_queues available in debugfs Bart Van Assche
2023-05-27  3:17   ` Luis Chamberlain
2023-05-22 22:25 ` [PATCH v5 5/9] block: Support submitting passthrough requests with small segments Bart Van Assche
2023-05-22 22:25 ` [PATCH v5 6/9] block: Add support for filesystem requests and " Bart Van Assche
2023-05-22 22:25 ` [PATCH v5 7/9] block: Add support for small segments in blk_rq_map_user_iov() Bart Van Assche
2023-05-22 22:25 ` [PATCH v5 8/9] scsi_debug: Support configuring the maximum segment size Bart Van Assche
2023-05-24 20:50   ` Douglas Gilbert
2023-05-22 22:25 ` [PATCH v5 9/9] null_blk: " Bart Van Assche
2023-06-09 17:14 ` [PATCH v5 0/9] Support limits below the page size Sandeep Dhavale
2023-06-12 18:15   ` Bart Van Assche
2023-06-12 18:34     ` Sandeep Dhavale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522222554.525229-3-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jyescas@google.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.