All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH 1/8] staging: media: atomisp: initialize settings to 0
Date: Wed, 24 May 2023 14:11:43 +0200	[thread overview]
Message-ID: <20230524121150.435736-2-hverkuil-cisco@xs4all.nl> (raw)
In-Reply-To: <20230524121150.435736-1-hverkuil-cisco@xs4all.nl>

Fix a compiler warning:

drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c:1525:13: warning: 'settings' may be used uninitialized [-Wmaybe-uninitialized]

The 'settings' variable is actually always initialized, but the
compiler isn't quite able to figure that out. Just initialize it
to 0 to avoid this warning.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index c718a74ea70a..48ba0d0bcfe5 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
@@ -1522,7 +1522,7 @@ static int v4l2_acpi_handle_gpio_res(struct acpi_resource *ares, void *_data)
 	const char *name;
 	bool active_low;
 	unsigned int i;
-	u32 settings;
+	u32 settings = 0;
 	u8 pin;
 
 	if (!acpi_gpio_get_io_resource(ares, &agpio))
-- 
2.39.2


  reply	other threads:[~2023-05-24 12:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 12:11 [PATCH 0/8] Various smatch/sparse fixes Hans Verkuil
2023-05-24 12:11 ` Hans Verkuil [this message]
2023-05-24 16:04   ` [PATCH 1/8] staging: media: atomisp: initialize settings to 0 Hans de Goede
2023-05-25  7:18     ` Hans Verkuil
2023-05-24 12:11 ` [PATCH 2/8] media: rockchip: rga: fix clock cleanup Hans Verkuil
2023-05-25  8:17   ` Michael Tretter
2023-05-24 12:11 ` [PATCH 3/8] media: usb: as102: drop as102_dev NULL check Hans Verkuil
2023-05-24 12:11 ` [PATCH 4/8] media: platform: renesas-ceu: drop buf " Hans Verkuil
2023-05-25 13:43   ` Jacopo Mondi
2023-05-24 12:11 ` [PATCH 5/8] media: platform: mediatek: vpu: fix NULL ptr dereference Hans Verkuil
2023-05-24 12:11 ` [PATCH 6/8] media: mediatek: vpu: add missing clk_unprepare Hans Verkuil
2023-05-24 12:11 ` [PATCH 7/8] media: pci: tw686x: no need to check 'next' Hans Verkuil
2023-05-24 12:11 ` [PATCH 8/8] staging: media: atomisp: move up sanity checks Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524121150.435736-2-hverkuil-cisco@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.