From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>,
Julien Grall <julien@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>,
Julien Grall <jgrall@amazon.com>
Subject: [PATCH v6 13/14] tools/xenstore: switch get_optval_int() to get_optval_uint()
Date: Tue, 30 May 2023 10:24:23 +0200 [thread overview]
Message-ID: <20230530082424.32126-14-jgross@suse.com> (raw)
In-Reply-To: <20230530082424.32126-1-jgross@suse.com>
Let get_optval_int() return an unsigned value and rename it
accordingly.
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
---
V5:
- new patch, carved out from next patch in series (Julien Grall)
---
tools/xenstore/xenstored_core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index dd00f74cb6..0a350dd6f8 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -2706,13 +2706,13 @@ int dom0_domid = 0;
int dom0_event = 0;
int priv_domid = 0;
-static int get_optval_int(const char *arg)
+static unsigned int get_optval_uint(const char *arg)
{
char *end;
- long val;
+ unsigned long val;
- val = strtol(arg, &end, 10);
- if (!*arg || *end || val < 0 || val > INT_MAX)
+ val = strtoul(arg, &end, 10);
+ if (!*arg || *end || val > INT_MAX)
barf("invalid parameter value \"%s\"\n", arg);
return val;
@@ -2732,7 +2732,7 @@ static void set_timeout(const char *arg)
if (!eq)
barf("quotas must be specified via <what>=<seconds>\n");
- val = get_optval_int(eq + 1);
+ val = get_optval_uint(eq + 1);
if (what_matches(arg, "watch-event"))
timeout_watch_event_msec = val * 1000;
else
@@ -2746,7 +2746,7 @@ static void set_quota(const char *arg, bool soft)
if (!eq)
barf("quotas must be specified via <what>=<nb>\n");
- val = get_optval_int(eq + 1);
+ val = get_optval_uint(eq + 1);
if (what_matches(arg, "outstanding") && !soft)
quota_req_outstanding = val;
else if (what_matches(arg, "transaction-nodes") && !soft)
--
2.35.3
next prev parent reply other threads:[~2023-05-30 8:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 8:24 [PATCH v6 00/14] tools/xenstore: rework internal accounting Juergen Gross
2023-05-30 8:24 ` [PATCH v6 01/14] tools/xenstore: take transaction internal nodes into account for quota Juergen Gross
2023-05-30 8:24 ` [PATCH v6 02/14] tools/xenstore: manage per-transaction domain accounting data in an array Juergen Gross
2023-05-30 8:24 ` [PATCH v6 03/14] tools/xenstore: introduce accounting data array for per-domain values Juergen Gross
2023-05-30 8:24 ` [PATCH v6 04/14] tools/xenstore: add framework to commit accounting data on success only Juergen Gross
2023-05-30 8:24 ` [PATCH v6 05/14] tools/xenstore: use accounting buffering for node accounting Juergen Gross
2023-06-07 10:49 ` Julien Grall
2023-05-30 8:24 ` [PATCH v6 06/14] tools/xenstore: add current connection to domain_memory_add() parameters Juergen Gross
2023-05-30 8:24 ` [PATCH v6 07/14] tools/xenstore: use accounting data array for per-domain values Juergen Gross
2023-05-30 8:24 ` [PATCH v6 08/14] tools/xenstore: add accounting trace support Juergen Gross
2023-05-30 8:24 ` [PATCH v6 09/14] tools/xenstore: add TDB access " Juergen Gross
2023-05-30 8:24 ` [PATCH v6 10/14] tools/xenstore: switch transaction accounting to generic accounting Juergen Gross
2023-05-30 8:24 ` [PATCH v6 11/14] tools/xenstore: remember global and per domain max accounting values Juergen Gross
2023-05-30 8:24 ` [PATCH v6 12/14] tools/xenstore: use generic accounting for remaining quotas Juergen Gross
2023-06-07 10:51 ` Julien Grall
2023-05-30 8:24 ` Juergen Gross [this message]
2023-05-30 8:24 ` [PATCH v6 14/14] tools/xenstore: switch quota management to be table based Juergen Gross
2023-06-07 12:38 ` [PATCH v6 00/14] tools/xenstore: rework internal accounting Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530082424.32126-14-jgross@suse.com \
--to=jgross@suse.com \
--cc=anthony.perard@citrix.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.