Re: [PATCH v5 35/44] tty: serial: handle HAS_IOPORT dependencies - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-pci@vger.kernel.org, "Arnd Bergmann" <arnd@kernel.org>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 35/44] tty: serial: handle HAS_IOPORT dependencies
Date: Tue, 30 May 2023 15:39:14 +0100	[thread overview]
Message-ID: <2023053050-prodigal-shine-4d1c@gregkh> (raw)
In-Reply-To: <20230522105049.1467313-36-schnelle@linux.ibm.com>

On Mon, May 22, 2023 at 12:50:40PM +0200, Niklas Schnelle wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them unconditionally. For 8250 based drivers some
> support MMIO only use so fence only the parts requiring I/O ports.
> 
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
>  drivers/tty/Kconfig                  |  4 +--
>  drivers/tty/serial/8250/8250_early.c |  4 +++
>  drivers/tty/serial/8250/8250_pci.c   | 14 +++++++++
>  drivers/tty/serial/8250/8250_port.c  | 44 +++++++++++++++++++++++-----
>  drivers/tty/serial/8250/Kconfig      |  5 ++--
>  drivers/tty/serial/Kconfig           |  2 +-
>  6 files changed, 60 insertions(+), 13 deletions(-)

This doesn't apply at all to my tree, so I'll just let you take it as
there must be some merge issues somewhere:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>