Re: [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200

From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Astrid Rost" <astridr@axis.com>,
	"Astrid Rost" <astrid.rost@axis.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@axis.com,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Mathieu Othacehe" <m.othacehe@gmail.com>
Subject: Re: [PATCH v4 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200
Date: Sun, 4 Jun 2023 14:10:02 +0100	[thread overview]
Message-ID: <20230604141002.0b055c10@jic23-huawei> (raw)
In-Reply-To: <CAHp75VdZAGhrXgYf5EOE6MQ4DiseaxOqkjUs+X9jROB1aonD_g@mail.gmail.com>

On Mon, 29 May 2023 12:02:16 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, May 29, 2023 at 10:41 AM Astrid Rost <astridr@axis.com> wrote:
> > Thanks for reviewing.
> > I can change this. But this is how it gets formatted by .clang-format.  
> 
> I would suggest to report the bug (in case it's not configurable) or
> configure to avoid such a misindentation.

I assume it's trading off line length against aligning with opening brackets.
Maybe made the wrong decision, but it is not totally unreasonable to my eyes.
I don't care either way though, so go with whatever you have for next version!

Jonathan

> 
> > On 5/29/23 00:45, andy.shevchenko@gmail.com wrote:  
> > > Mon, May 22, 2023 at 04:26:18PM +0200, Astrid Rost kirjoitti:  
> > >> Add support to configure ambient light sensor interrupts and threshold
> > >> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
> > >> will be pushed to the event interface.  
> > >
> > > ...
> > >  
> > >> +            case IIO_EV_DIR_RISING:
> > >> +                    ret = i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_ALS_THDH_LM, val);  
> > >
> > > Strange indentation.
> > >  
> > >> +                    break;
> > >> +            case IIO_EV_DIR_FALLING:
> > >> +                    ret = i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_ALS_THDL_LM, val);  
> > >
> > > Same.
> > >  
> > >> +                    break;  
> > >
> > > ...
> > >  
> > >> +    case IIO_PROXIMITY:
> > >> +            switch (dir) {
> > >> +            case IIO_EV_DIR_RISING:
> > >> +                    ret = i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_PS_THDH_LM, val);  
> > >
> > > Same.
> > >  
> > >> +                    break;
> > >> +            case IIO_EV_DIR_FALLING:
> > >> +                    ret = i2c_smbus_write_word_data(
> > >> +                            data->client, VCNL4040_PS_THDL_LM, val);  
> > >
> > > Same.  
> 