Re: [PATCH v15 5/5] arm64: dts: qcom: ipq9574: Enable USB

From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <gregkh@linuxfoundation.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <quic_wcheng@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v15 5/5] arm64: dts: qcom: ipq9574: Enable USB
Date: Wed, 21 Jun 2023 13:20:07 +0530	[thread overview]
Message-ID: <20230621075006.GA3533@varda-linux.qualcomm.com> (raw)
In-Reply-To: <5021dbf3a28ee073795e7580bfa019df465e16ed.1686289721.git.quic_varada@quicinc.com>

On Fri, Jun 09, 2023 at 11:26:34AM +0530, Varadarajan Narayanan wrote:
> Add regulator defines
> Turn on USB related nodes
> Provide vdd info
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
>  Changes in v15:
> 	- Move fixed regulator defines from 'arm64: dts: qcom: ipq9574: Add USB related nodes' to this patch
> 
>  Changes in v13:
> 	- s/fixed_/regulator_fixed_/
> 
>  Changes in v11:
> 	- Rename dwc_0 -> usb_0_dwc3
> 	- Maintain sorted order for the usb nodes
> 
>  Changes in v10:
> 	- Provide vdd info
> 
>  Changes in v5:
> 	- Move "host" mode specification to board dts
> 	- Due to dependency with earlier patches board dts
> 	  filename changed ipq9574-al02-c7.dts -> ipq9574-rdp433.dts
> 
>  Changes in v2:
> 	- Fix node placement and coding style
> 	- "ok" -> "okay"
> ---
>  arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 41 +++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> index 8c2451c..877026c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> @@ -21,6 +21,24 @@
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	regulator_fixed_3p3: s3300 {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +		regulator-name = "fixed_3p3";
> +	};
> +
> +	regulator_fixed_0p925: s0925 {
> +		compatible = "regulator-fixed";
> +		regulator-min-microvolt = <925000>;
> +		regulator-max-microvolt = <925000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +		regulator-name = "fixed_0p925";
> +	};
>  };
>  
>  &blsp1_uart2 {
> @@ -105,6 +123,29 @@
>  	};
>  };
>  
> +&usb_0_dwc3 {
> +	dr_mode = "host";
> +};
> +
> +&usb_0_qmpphy {
> +	vdda-pll-supply = <&mp5496_l2>;
> +	vdda-phy-supply = <&regulator_fixed_0p925>;
> +
> +	status = "okay";
> +};
> +
> +&usb_0_qusbphy {
> +	vdd-supply = <&regulator_fixed_0p925>;
> +	vdda-pll-supply = <&mp5496_l2>;
> +	vdda-phy-dpdm-supply = <&regulator_fixed_3p3>;
> +
> +	status = "okay";
> +};
> +
> +&usb3 {
> +	status = "okay";
> +};
> +
>  &xo_board_clk {
>  	clock-frequency = <24000000>;
>  };
> -- 
> 2.7.4
> 

Bjorn,

Can this be pulled for 6.5?

Thanks
Varada