From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: [PATCH v2 00/13] parse-events clean up
Date: Tue, 27 Jun 2023 11:10:17 -0700 [thread overview]
Message-ID: <20230627181030.95608-1-irogers@google.com> (raw)
Remove some tokens the lexer never produces. Ensure abort paths set an
error. Previously scanning all PMUs meant bad events could fail with
an invalid token, detect this at the point parsing for a PMU fails and
add error strings. Try to be consistent in using YYNOMEM for memory
failures and YYABORT for bad input.
v2. Fix build error when building without libtraceevent.
Ian Rogers (13):
perf parse-events: Remove unused PE_PMU_EVENT_FAKE token
perf parse-events: Remove unused PE_KERNEL_PMU_EVENT token
perf parse-events: Remove two unused tokens
perf parse-events: Add more comments to parse_events_state
perf parse-events: Avoid regrouped warning for wild card events
perf parse-event: Add memory allocation test for name terms
perf parse-events: Separate YYABORT and YYNOMEM cases
perf parse-events: Move instances of YYABORT to YYNOMEM
perf parse-events: Separate ENOMEM memory handling
perf parse-events: Additional error reporting
perf parse-events: Populate error column for BPF/tracepoint events
perf parse-events: Improve location for add pmu
perf parse-events: Remove ABORT_ON
tools/perf/tests/bpf.c | 2 +-
tools/perf/util/parse-events.c | 98 +++++----
tools/perf/util/parse-events.h | 20 +-
tools/perf/util/parse-events.y | 351 +++++++++++++++++----------------
4 files changed, 258 insertions(+), 213 deletions(-)
--
2.41.0.162.gfafddb0af9-goog
next reply other threads:[~2023-06-27 18:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 18:10 Ian Rogers [this message]
2023-06-27 18:10 ` [PATCH v2 01/13] perf parse-events: Remove unused PE_PMU_EVENT_FAKE token Ian Rogers
2023-06-30 16:35 ` Markus Elfring
2023-06-30 17:05 ` Ian Rogers
2023-06-30 17:15 ` [v2 " Markus Elfring
2023-06-30 17:16 ` Ian Rogers
2023-06-30 17:23 ` Markus Elfring
2023-06-30 17:33 ` Ian Rogers
2023-06-30 17:52 ` Markus Elfring
2023-06-30 18:01 ` Ian Rogers
2023-07-01 8:00 ` Markus Elfring
2023-07-03 12:46 ` [PATCH v2 " Dan Carpenter
2023-07-03 13:08 ` [v2 " Markus Elfring
2023-06-27 18:10 ` [PATCH v2 02/13] perf parse-events: Remove unused PE_KERNEL_PMU_EVENT token Ian Rogers
2023-06-27 18:10 ` [PATCH v2 03/13] perf parse-events: Remove two unused tokens Ian Rogers
2023-06-27 18:10 ` [PATCH v2 04/13] perf parse-events: Add more comments to parse_events_state Ian Rogers
2023-06-27 18:10 ` [PATCH v2 05/13] perf parse-events: Avoid regrouped warning for wild card events Ian Rogers
2023-06-27 18:10 ` [PATCH v2 06/13] perf parse-event: Add memory allocation test for name terms Ian Rogers
2023-06-27 18:10 ` [PATCH v2 07/13] perf parse-events: Separate YYABORT and YYNOMEM cases Ian Rogers
2023-06-27 18:10 ` [PATCH v2 08/13] perf parse-events: Move instances of YYABORT to YYNOMEM Ian Rogers
2023-06-27 18:10 ` [PATCH v2 09/13] perf parse-events: Separate ENOMEM memory handling Ian Rogers
2023-06-27 18:10 ` [PATCH v2 10/13] perf parse-events: Additional error reporting Ian Rogers
2023-06-27 18:10 ` [PATCH v2 11/13] perf parse-events: Populate error column for BPF/tracepoint events Ian Rogers
2023-06-27 18:10 ` [PATCH v2 12/13] perf parse-events: Improve location for add pmu Ian Rogers
2023-06-27 18:10 ` [PATCH v2 13/13] perf parse-events: Remove ABORT_ON Ian Rogers
2023-06-29 21:49 ` Namhyung Kim
2023-06-30 15:14 ` Ian Rogers
2023-07-01 18:43 ` Namhyung Kim
2023-07-12 5:01 ` Ian Rogers
2023-06-30 16:56 ` Markus Elfring
2023-06-30 17:06 ` Ian Rogers
2023-06-30 17:40 ` [v2 " Markus Elfring
2023-06-30 18:05 ` Ian Rogers
2023-07-01 9:00 ` Markus Elfring
2023-07-01 9:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627181030.95608-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.