Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h

From: "Krzysztof Wilczyński" <kw@linux.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Alistair Francis <alistair@alistair23.me>,
	marek.vasut+renesas@gmail.com, yoshihiro.shimoda.uh@renesas.com,
	linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org, lpieralisi@kernel.org,
	robh@kernel.org, bhelgaas@google.com, alistair23@gmail.com
Subject: Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h
Date: Wed, 5 Jul 2023 20:44:43 +0900	[thread overview]
Message-ID: <20230705114443.GA3555378@rocinante> (raw)
In-Reply-To: <7536d9a3-4738-2bc2-e33e-d93347893865@kernel.org>

Hello,

> > pci-epc.h doesn't define the members of the pci_epf_header struct, so
> > trying to access them results in errors like this:
> > 
> >     error: invalid use of undefined type 'struct pci_epf_header'
> >       167 |                 val = hdr->vendorid;
> > 
> > Instead let's include pci-epf.h which not only defines the
> > pci_epf_header but also includes pci-epc.h.

[...]
> It is odd that the the build bot did not detect this...

This is a bit of a surprise to me too, especially since none of the usual
bots pick this up, and I can't seem to find such a failure in the nightly
CI logs either.

Alistair, how did you stumble into this issue?  Also, which version or
a tree would that be?

  Thank you!

	Krzysztof