From: Eric Van Hensbergen <ericvh@kernel.org>
To: Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@pengutronix.de,
Robert Schwebel <r.schwebel@pengutronix.de>,
Eric Van Hensbergen <ericvh@kernel.org>
Subject: [PATCH v2 2/4] fs/9p: fix typo in comparison logic for cache mode
Date: Tue, 18 Jul 2023 20:50:16 +0000 [thread overview]
Message-ID: <20230716-fixes-overly-restrictive-mmap-v2-2-147d6b93f699@kernel.org> (raw)
In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v2-0-147d6b93f699@kernel.org>
There appears to be a typo in the comparison statement for the logic
which sets a file's cache mode based on mount flags.
Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
---
fs/9p/fid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/9p/fid.h b/fs/9p/fid.h
index 0c51889a60b33..297c2c377e3dd 100644
--- a/fs/9p/fid.h
+++ b/fs/9p/fid.h
@@ -57,7 +57,7 @@ static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags,
(s_flags & V9FS_DIRECT_IO) || (f_flags & O_DIRECT)) {
fid->mode |= P9L_DIRECT; /* no read or write cache */
} else if ((!(s_cache & CACHE_WRITEBACK)) ||
- (f_flags & O_DSYNC) | (s_flags & V9FS_SYNC)) {
+ (f_flags & O_DSYNC) || (s_flags & V9FS_SYNC)) {
fid->mode |= P9L_NOWRITECACHE;
}
}
--
2.39.2
next prev parent reply other threads:[~2023-07-18 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 20:50 [PATCH v2 0/4] fs/9p: fix mmap regression Eric Van Hensbergen
2023-07-18 20:50 ` [PATCH v2 1/4] fs/9p: remove unnecessary and overrestrictive check Eric Van Hensbergen
2023-07-19 13:18 ` Christian Schoenebeck
2023-07-18 20:50 ` Eric Van Hensbergen [this message]
2023-07-18 20:50 ` [PATCH v2 3/4] fs/9p: fix type mismatch in file cache mode helper Eric Van Hensbergen
2023-07-18 20:50 ` [PATCH v2 4/4] fs/9p: remove unnecessary invalidate_inode_pages2 Eric Van Hensbergen
2023-07-19 13:08 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716-fixes-overly-restrictive-mmap-v2-2-147d6b93f699@kernel.org \
--to=ericvh@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=r.schwebel@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.