From: Steven Rostedt <rostedt@goodmis.org>
To: Ajay Kaher <akaher@vmware.com>
Cc: "shuah@kernel.org" <shuah@kernel.org>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
Ching-lin Yu <chinglinyu@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, lkp@intel.com,
Nadav Amit <namit@vmware.com>,
"oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>,
Alexey Makhalov <amakhalov@vmware.com>,
"er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>,
"srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
Tapas Kundu <tkundu@vmware.com>,
Vasavi Sirnapalli <vsirnapalli@vmware.com>
Subject: Re: [PATCH v4 00/10] tracing: introducing eventfs
Date: Fri, 21 Jul 2023 15:14:09 -0400 [thread overview]
Message-ID: <20230721151409.212791c0@gandalf.local.home> (raw)
In-Reply-To: <20230721091843.68c4d6e7@gandalf.local.home>
On Fri, 21 Jul 2023 09:18:43 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> OK, I got this working and it appears to pass all my tests. I actually got
> it working Wednesday night, but I tried a different approach on Thursday
> that got rid of the evenfs_file and only used eventfs_inodes and makes the
> files more dynamic. There's still a couple of corner cases that are not
> working with this approach (the dentry counters are getting out of sync).
> This should not stop this from going in. I'll continue working on that
> approach for the next merge cycle. But for now, here's the patch to this
> series that works.
Just figured out my bug with my new design. It was in the eventfs_release()
code, where I have a loop that does the dput on the children, but I wasn't
dput(child), I was dput(parent) in that loop!!
Anyway, for this merge window I much rather have this code in, and for the
next merge window I'll add this update.
I can post the new design too, but first let's focus on this.
-- Steve
prev parent reply other threads:[~2023-07-21 19:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 11:33 [PATCH v4 00/10] tracing: introducing eventfs Ajay Kaher
2023-07-13 11:33 ` [PATCH v4 01/10] tracing: Require all trace events to have a TRACE_SYSTEM Ajay Kaher
2023-07-13 11:33 ` [PATCH v4 02/10] tracefs: Rename some tracefs function Ajay Kaher
2023-07-14 15:11 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 03/10] eventfs: Implement eventfs dir creation functions Ajay Kaher
2023-07-14 15:44 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 04/10] eventfs: Implement eventfs file add functions Ajay Kaher
2023-07-14 16:23 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 05/10] eventfs: Implement eventfs file, directory remove function Ajay Kaher
2023-07-14 16:35 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 06/10] eventfs: Implement functions to create eventfs files and directories Ajay Kaher
2023-07-14 16:47 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 07/10] eventfs: Implement eventfs lookup, read, open functions Ajay Kaher
2023-07-14 20:17 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 08/10] eventfs: Implement tracefs_inode_cache Ajay Kaher
2023-07-14 20:27 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 09/10] eventfs: Move tracing/events to eventfs Ajay Kaher
2023-07-14 21:06 ` Steven Rostedt
2023-07-19 11:08 ` Ajay Kaher
2023-07-19 11:08 ` Ajay Kaher
2023-09-08 12:14 ` Sven Schnelle
2023-09-08 12:31 ` Steven Rostedt
2023-07-13 11:33 ` [PATCH v4 10/10] test: ftrace: Fix kprobe test for eventfs Ajay Kaher
2023-07-14 2:37 ` Steven Rostedt
2023-07-14 13:27 ` Masami Hiramatsu
2023-07-17 5:24 ` Ajay Kaher
2023-07-17 12:24 ` Steven Rostedt
2023-07-14 22:58 ` [PATCH v4 00/10] tracing: introducing eventfs Steven Rostedt
2023-07-16 17:32 ` Ajay Kaher
2023-07-18 13:40 ` Steven Rostedt
2023-07-19 10:25 ` Ajay Kaher
2023-07-19 14:23 ` Steven Rostedt
2023-07-19 18:37 ` Ajay Kaher
2023-07-19 18:40 ` Steven Rostedt
2023-07-21 12:48 ` Steven Rostedt
2023-07-21 13:16 ` Steven Rostedt
2023-07-21 13:19 ` Steven Rostedt
2023-07-21 17:17 ` Nadav Amit
2023-07-21 17:24 ` Steven Rostedt
2023-07-21 17:30 ` Steven Rostedt
2023-07-21 20:40 ` Steven Rostedt
2023-07-26 18:54 ` Ajay Kaher
2023-07-21 13:18 ` Steven Rostedt
2023-07-21 19:14 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721151409.212791c0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=chinglinyu@google.com \
--cc=er.ajay.kaher@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mhiramat@kernel.org \
--cc=namit@vmware.com \
--cc=oe-lkp@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=srivatsa@csail.mit.edu \
--cc=tkundu@vmware.com \
--cc=vsirnapalli@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.