From: Andrey Albershteyn <aalbersh@redhat.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH] fstests: add helper to canonicalize devices used to enable persistent disks
Date: Mon, 24 Jul 2023 12:58:08 +0200 [thread overview]
Message-ID: <20230724105808.dxyszzkzcwf7y7od@aalbersh.remote.csb> (raw)
In-Reply-To: <20230720061727.2363548-1-mcgrof@kernel.org>
On 2023-07-19 23:17:27, Luis Chamberlain wrote:
> The filesystem configuration file does not allow you to use symlinks to
> devices given the existing sanity checks verify that the target end
> device matches the source.
>
> Using a symlink is desirable if you want to enable persistent tests
> across reboots. For example you may want to use /dev/disk/by-id/nvme-eui.*
> so to ensure that the same drives are used even after reboot. This
> is very useful if you are testing for example with a virtualized
> environment and are using PCIe passthrough with other qemu NVMe drives
> with one or many NVMe drives.
>
> To enable support just add a helper to canonicalize devices prior to
> running the tests.
>
> This allows one test runner, kdevops, which I just extended with
> support to use real NVMe drives. The drives it uses for the filesystem
> configuration optionally is with NVMe eui symlinks so to allow
> the same drives to be used over reboots.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
Looks good to me:
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>
--
- Andrey
next prev parent reply other threads:[~2023-07-24 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 6:17 [PATCH] fstests: add helper to canonicalize devices used to enable persistent disks Luis Chamberlain
2023-07-24 10:58 ` Andrey Albershteyn [this message]
2023-07-25 8:13 ` Zorro Lang
2023-07-25 15:54 ` Darrick J. Wong
2023-07-25 17:50 ` Zorro Lang
2023-07-26 17:34 ` Luis Chamberlain
2023-07-26 4:41 ` Theodore Ts'o
2023-07-26 16:28 ` Luis Chamberlain
2023-07-27 1:13 ` Theodore Ts'o
2023-07-27 1:26 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724105808.dxyszzkzcwf7y7od@aalbersh.remote.csb \
--to=aalbersh@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.