From: Andrew Morton <akpm@linux-foundation.org>
To: "Andrew Yang" <Andrew.Yang@mediatek.com>
Cc: "senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Casper Li" <casper.li@mediatek.com>,
"minchan@kernel.org" <minchan@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] zsmalloc: Fix races between modifications of fullness and isolated
Date: Wed, 26 Jul 2023 13:18:22 -0700 [thread overview]
Message-ID: <20230726131822.22ac039ee4c696ea0726b510@linux-foundation.org> (raw)
In-Reply-To: <42f1209a686404ffd0f9dff05ed10a8d23383a11.camel@mediatek.com>
On Wed, 26 Jul 2023 06:59:20 +0000 Andrew Yang (楊智強) <Andrew.Yang@mediatek.com> wrote:
> > Have you observed issues in real life? That commit is more than a
> > year
> > and a half old, so I wonder.
> >
> Yes, we encountered many kernel exceptions of
> VM_BUG_ON(zspage->isolated == 0) in dec_zspage_isolation() and
> BUG_ON(!pages[1]) in zs_unmap_object() lately.
> This issue only occurs when migration and reclamation occur at the
> same time. With our memory stress test, we can reproduce this issue
> several times a day. We have no idea why no one else encountered
> this issue. BTW, we switched to the new kernel version with this
> defect a few months ago.
Ah. It's important that such information be in the changelog!
I have put this info into my copy of the v1 patch's changelog.
I have moved the v1 patch from the mm-unstable branch into
mm-hotfixes-unstable, so it is staged for merging in this -rc cycle.
I have also added a cc:stable so that the fix gets backported into
kernels which contain c4549b871102.
I have added a note-to-self that a v2 patch is expected.
prev parent reply other threads:[~2023-07-26 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 6:37 [PATCH] zsmalloc: Fix races between modifications of fullness and isolated Andrew Yang
2023-07-21 6:37 ` Andrew Yang
2023-07-26 2:31 ` Sergey Senozhatsky
2023-07-26 2:57 ` Sergey Senozhatsky
2023-07-26 3:18 ` Sergey Senozhatsky
2023-07-26 6:59 ` Andrew Yang (楊智強)
2023-07-26 11:31 ` Sergey Senozhatsky
2023-07-26 20:18 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726131822.22ac039ee4c696ea0726b510@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Andrew.Yang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bigeasy@linutronix.de \
--cc=casper.li@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.