All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	Wen Xiong <wenxiong@linux.ibm.com>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2 0/9] blk-mq: fix wrong queue mapping for kdump kernel
Date: Mon, 31 Jul 2023 09:14:09 +0200	[thread overview]
Message-ID: <20230731071409.GA31608@lst.de> (raw)
In-Reply-To: <20230726094027.535126-1-ming.lei@redhat.com>

On Wed, Jul 26, 2023 at 05:40:18PM +0800, Ming Lei wrote:
> Hi,
> 
> On arm and ppc64, 'maxcpus=1' is required for kdump kernel,
> see `Documentation/admin-guide/kdump/kdump.rst`, so num_possible_cpus()
> still returns all CPUs because 'maxcpus=1' just bring up one single
> cpu core during booting.

Just as said last time:  Please drop the odd is_kdump_kernel checks
in blk_mq_update_queue_map and blk_mq_alloc_tag_set instead of sprinkling
this crap even further. 


      parent reply	other threads:[~2023-07-31  7:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  9:40 [PATCH V2 0/9] blk-mq: fix wrong queue mapping for kdump kernel Ming Lei
2023-07-26  9:40 ` [PATCH V2 1/9] blk-mq: add blk_mq_max_nr_hw_queues() Ming Lei
2023-07-26 16:36   ` John Garry
2023-07-27  1:06     ` Ming Lei
2023-07-26  9:40 ` [PATCH V2 2/9] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues Ming Lei
2023-07-26  9:40 ` [PATCH V2 3/9] scsi: core: add helper of scsi_max_nr_hw_queues() Ming Lei
2023-07-26  9:40 ` [PATCH V2 4/9] scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors Ming Lei
2023-07-26 22:12   ` Justin Tee
2023-07-27  1:19     ` Ming Lei
2023-07-27 16:56       ` Justin Tee
2023-07-26  9:40 ` [PATCH V2 5/9] scsi: hisi: take blk_mq_max_nr_hw_queues() into account for calculating " Ming Lei
2023-07-26 15:42   ` John Garry
2023-07-27  1:15     ` Ming Lei
2023-07-27  7:35       ` John Garry
2023-07-27  9:42         ` Ming Lei
2023-07-27 10:28           ` John Garry
2023-07-27 10:56             ` Ming Lei
2023-07-27 11:30               ` John Garry
2023-07-27 12:01                 ` Ming Lei
2023-07-27 12:36                   ` John Garry
2023-07-26  9:40 ` [PATCH V2 6/9] scsi: mpi3mr: " Ming Lei
2023-07-26  9:40 ` [PATCH V2 7/9] scsi: megaraid: " Ming Lei
2023-07-26  9:40 ` [PATCH V2 8/9] scsi: mpt3sas: " Ming Lei
2023-07-26  9:40 ` [PATCH V2 9/9] scsi: pm8001: " Ming Lei
2023-07-31  7:14 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731071409.GA31608@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=wenxiong@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.