Re: [PATCH -next] usb: isp116x-hcd: Remove unnecessary check of res - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: linux-usb@vger.kernel.org, Olav Kongas <ok@artecdesign.ee>
Subject: Re: [PATCH -next] usb: isp116x-hcd: Remove unnecessary check of res
Date: Wed, 16 Aug 2023 16:46:39 +0200	[thread overview]
Message-ID: <2023081659-bakery-ladybug-1a35@gregkh> (raw)
In-Reply-To: <20230816073432.221665-1-ruanjinjie@huawei.com>

On Wed, Aug 16, 2023 at 03:34:32PM +0800, Ruan Jinjie wrote:
> The resource is checked in probe function, so there is
> no need do this check in remove function.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
>  drivers/usb/host/isp116x-hcd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
> index a82d8926e922..c95a9b004412 100644
> --- a/drivers/usb/host/isp116x-hcd.c
> +++ b/drivers/usb/host/isp116x-hcd.c
> @@ -1540,12 +1540,10 @@ static void isp116x_remove(struct platform_device *pdev)
>  
>  	iounmap(isp116x->data_reg);
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	if (res)
> -		release_mem_region(res->start, 2);
> +	release_mem_region(res->start, 2);
>  	iounmap(isp116x->addr_reg);
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (res)
> -		release_mem_region(res->start, 2);
> +	release_mem_region(res->start, 2);

Perhaps, but now you will get in a fight with the "auto fix tools" that
will notice that those functions can fail, so the return value must be
checked.

So you are in an argument you can't win, let's just leave these as-is to
keep the static-tool-checkers happy.  It's on a remove path, it doesn't
really matter.

thanks,

greg k-h