From: Alexander Aring <aahringo@redhat.com> To: linux-nfs@vger.kernel.org Cc: jlayton@kernel.org, cluster-devel@redhat.com, ocfs2-devel@lists.linux.dev, chuck.lever@oracle.com, anna@kernel.org, linux-fsdevel@vger.kernel.org, trond.myklebust@hammerspace.com Subject: [Cluster-devel] [PATCH 6/7] dlm: use FL_SLEEP to determine blocking vs non-blocking Date: Wed, 23 Aug 2023 17:33:51 -0400 [thread overview] Message-ID: <20230823213352.1971009-7-aahringo@redhat.com> (raw) In-Reply-To: <20230823213352.1971009-1-aahringo@redhat.com> This patch uses the FL_SLEEP flag in struct file_lock to determine if the lock request is a blocking or non-blocking request. Before dlm was using IS_SETLKW() was being used which is not usable for lock requests coming from lockd when EXPORT_OP_SAFE_ASYNC_LOCK inside the export flags is set. Signed-off-by: Alexander Aring <aahringo@redhat.com> --- fs/dlm/plock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c index 0094fa4004cc..0c6ed5eeb840 100644 --- a/fs/dlm/plock.c +++ b/fs/dlm/plock.c @@ -140,7 +140,7 @@ int dlm_posix_lock(dlm_lockspace_t *lockspace, u64 number, struct file *file, op->info.optype = DLM_PLOCK_OP_LOCK; op->info.pid = fl->fl_pid; op->info.ex = (fl->fl_type == F_WRLCK); - op->info.wait = IS_SETLKW(cmd); + op->info.wait = !!(fl->fl_flags & FL_SLEEP); op->info.fsid = ls->ls_global_id; op->info.number = number; op->info.start = fl->fl_start; -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Aring <aahringo@redhat.com> To: linux-nfs@vger.kernel.org Cc: cluster-devel@redhat.com, ocfs2-devel@lists.linux.dev, linux-fsdevel@vger.kernel.org, teigland@redhat.com, rpeterso@redhat.com, agruenba@redhat.com, trond.myklebust@hammerspace.com, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org Subject: [PATCH 6/7] dlm: use FL_SLEEP to determine blocking vs non-blocking Date: Wed, 23 Aug 2023 17:33:51 -0400 [thread overview] Message-ID: <20230823213352.1971009-7-aahringo@redhat.com> (raw) In-Reply-To: <20230823213352.1971009-1-aahringo@redhat.com> This patch uses the FL_SLEEP flag in struct file_lock to determine if the lock request is a blocking or non-blocking request. Before dlm was using IS_SETLKW() was being used which is not usable for lock requests coming from lockd when EXPORT_OP_SAFE_ASYNC_LOCK inside the export flags is set. Signed-off-by: Alexander Aring <aahringo@redhat.com> --- fs/dlm/plock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c index 0094fa4004cc..0c6ed5eeb840 100644 --- a/fs/dlm/plock.c +++ b/fs/dlm/plock.c @@ -140,7 +140,7 @@ int dlm_posix_lock(dlm_lockspace_t *lockspace, u64 number, struct file *file, op->info.optype = DLM_PLOCK_OP_LOCK; op->info.pid = fl->fl_pid; op->info.ex = (fl->fl_type == F_WRLCK); - op->info.wait = IS_SETLKW(cmd); + op->info.wait = !!(fl->fl_flags & FL_SLEEP); op->info.fsid = ls->ls_global_id; op->info.number = number; op->info.start = fl->fl_start; -- 2.31.1
next prev parent reply other threads:[~2023-08-23 21:34 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-23 21:33 [PATCH 0/7] lockd: dlm: async lock request changes Alexander Aring 2023-08-23 21:33 ` [Cluster-devel] " Alexander Aring 2023-08-23 21:33 ` [PATCH 1/7] lockd: introduce safe async lock op Alexander Aring 2023-08-23 21:33 ` [Cluster-devel] " Alexander Aring 2023-08-25 17:21 ` Chuck Lever 2023-08-25 17:21 ` [Cluster-devel] " Chuck Lever 2023-08-30 12:32 ` Alexander Aring 2023-08-30 12:32 ` [Cluster-devel] " Alexander Aring 2023-08-30 13:45 ` Chuck Lever 2023-08-30 13:45 ` [Cluster-devel] " Chuck Lever 2023-08-25 18:14 ` Jeff Layton 2023-08-25 18:14 ` [Cluster-devel] " Jeff Layton 2023-08-23 21:33 ` [PATCH 2/7] lockd: don't call vfs_lock_file() for pending requests Alexander Aring 2023-08-23 21:33 ` [Cluster-devel] " Alexander Aring 2023-08-25 18:10 ` Jeff Layton 2023-08-25 18:10 ` [Cluster-devel] " Jeff Layton 2023-08-30 12:15 ` Alexander Aring 2023-08-30 12:15 ` [Cluster-devel] " Alexander Aring 2023-08-23 21:33 ` [PATCH 3/7] lockd: fix race in async lock request handling Alexander Aring 2023-08-23 21:33 ` [Cluster-devel] " Alexander Aring 2023-08-25 17:35 ` Chuck Lever 2023-08-25 17:35 ` [Cluster-devel] " Chuck Lever 2023-08-25 18:16 ` Jeff Layton 2023-08-25 18:16 ` Jeff Layton 2023-08-23 21:33 ` [Cluster-devel] [PATCH 4/7] lockd: add doc to enable EXPORT_OP_SAFE_ASYNC_LOCK Alexander Aring 2023-08-23 21:33 ` Alexander Aring 2023-08-25 18:17 ` Jeff Layton 2023-08-25 18:17 ` [Cluster-devel] " Jeff Layton 2023-08-23 21:33 ` [Cluster-devel] [PATCH 5/7] dlm: use fl_owner from lockd Alexander Aring 2023-08-23 21:33 ` Alexander Aring 2023-08-23 21:33 ` Alexander Aring [this message] 2023-08-23 21:33 ` [PATCH 6/7] dlm: use FL_SLEEP to determine blocking vs non-blocking Alexander Aring 2023-08-25 18:18 ` [Cluster-devel] " Jeff Layton 2023-08-25 18:18 ` Jeff Layton 2023-08-30 12:38 ` Alexander Aring 2023-08-30 12:38 ` [Cluster-devel] " Alexander Aring 2023-08-30 13:46 ` Jeff Layton 2023-08-30 13:46 ` [Cluster-devel] " Jeff Layton 2023-08-23 21:33 ` [Cluster-devel] [PATCH 7/7] dlm: implement EXPORT_OP_SAFE_ASYNC_LOCK Alexander Aring 2023-08-23 21:33 ` Alexander Aring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230823213352.1971009-7-aahringo@redhat.com \ --to=aahringo@redhat.com \ --cc=anna@kernel.org \ --cc=chuck.lever@oracle.com \ --cc=cluster-devel@redhat.com \ --cc=jlayton@kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=ocfs2-devel@lists.linux.dev \ --cc=trond.myklebust@hammerspace.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.