From: Nathan Chancellor <nathan@kernel.org>
To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org
Cc: mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
patches@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] clk: qcom: Fix SM_GPUCC_8450 dependencies
Date: Tue, 29 Aug 2023 07:08:47 -0700 [thread overview]
Message-ID: <20230829-fix-sm_gpucc_8550-deps-v1-1-d751f6cd35b2@kernel.org> (raw)
CONFIG_SM_GCC_8450 depends on ARM64 but it is selected by
CONFIG_SM_GPUCC_8450, which can be selected on ARM, resulting in a
Kconfig warning.
WARNING: unmet direct dependencies detected for SM_GCC_8450
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [y]:
- SM_GPUCC_8450 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
Add the same dependencies to CONFIG_SM_GPUCC_8450 to resolve the
warning.
Fixes: 728692d49edc ("clk: qcom: Add support for SM8450 GPUCC")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
I think this is more of a silent conflict between commit ab7f00379fe9
("clk: qcom: restrict drivers per ARM/ARM64") and commit 728692d49edc
("clk: qcom: Add support for SM8450 GPUCC"), rather than just a fault of
728692d49edc but ab7f00379fe9 was merged first so I just chose
728692d49edc as the problematic commit for the message, feel free to
adjust it as necessary.
---
drivers/clk/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index bd9bfb11b328..865db5202e4c 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -986,6 +986,7 @@ config SM_GPUCC_8350
config SM_GPUCC_8450
tristate "SM8450 Graphics Clock Controller"
+ depends on ARM64 || COMPILE_TEST
select SM_GCC_8450
help
Support for the graphics clock controller on SM8450 devices.
---
base-commit: e1cd74b6dccb98ca09e4612ff29c7658db7a487b
change-id: 20230829-fix-sm_gpucc_8550-deps-963aa04323f2
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
next reply other threads:[~2023-08-29 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 14:08 Nathan Chancellor [this message]
2023-08-29 20:46 ` [PATCH] clk: qcom: Fix SM_GPUCC_8450 dependencies Konrad Dybcio
2023-08-29 22:29 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829-fix-sm_gpucc_8550-deps-v1-1-d751f6cd35b2@kernel.org \
--to=nathan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=patches@lists.linux.dev \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.