From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
treding@nvidia.com, jonathanh@nvidia.com, bbasu@nvidia.com
Subject: Re: [Patch v2] cpufreq: tegra194: fix warning due to missing opp_put
Date: Tue, 29 Aug 2023 14:33:43 +0530 [thread overview]
Message-ID: <20230829090343.kyyfsienwo4aiu2p@vireshk-i7> (raw)
In-Reply-To: <20230829084322.30558-1-sumitg@nvidia.com>
On 29-08-23, 14:13, Sumit Gupta wrote:
> Fix the warning due to missing dev_pm_opp_put() call and hence
> wrong refcount value. This causes below warning message when
> trying to remove the module.
>
> Call trace:
> dev_pm_opp_put_opp_table+0x154/0x15c
> dev_pm_opp_remove_table+0x34/0xa0
> _dev_pm_opp_cpumask_remove_table+0x7c/0xbc
> dev_pm_opp_of_cpumask_remove_table+0x10/0x18
> tegra194_cpufreq_exit+0x24/0x34 [tegra194_cpufreq]
> cpufreq_remove_dev+0xa8/0xf8
> subsys_interface_unregister+0x90/0xe8
> cpufreq_unregister_driver+0x54/0x9c
> tegra194_cpufreq_remove+0x18/0x2c [tegra194_cpufreq]
> platform_remove+0x24/0x74
> device_remove+0x48/0x78
> device_release_driver_internal+0xc8/0x160
> driver_detach+0x4c/0x90
> bus_remove_driver+0x68/0xb8
> driver_unregister+0x2c/0x58
> platform_driver_unregister+0x10/0x18
> tegra194_ccplex_driver_exit+0x14/0x1e0 [tegra194_cpufreq]
> __arm64_sys_delete_module+0x184/0x270
>
> Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidth")
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> drivers/cpufreq/tegra194-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 88ef5e57ccd0..9d7e1d58f6e5 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -450,6 +450,7 @@ static int tegra_cpufreq_init_cpufreq_table(struct cpufreq_policy *policy,
> if (IS_ERR(opp))
> continue;
>
> + dev_pm_opp_put(opp);
> ret = dev_pm_opp_enable(cpu_dev, pos->frequency * KHZ);
> if (ret < 0)
> return ret;
Applied. Thanks.
--
viresh
prev parent reply other threads:[~2023-08-29 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 8:43 [Patch v2] cpufreq: tegra194: fix warning due to missing opp_put Sumit Gupta
2023-08-29 9:03 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829090343.kyyfsienwo4aiu2p@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bbasu@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.