From: Jonathan Cameron <jic23@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Marek Vasut" <marex@denx.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Biju Das" <biju.das.au@gmail.com>
Subject: Re: [PATCH v3 0/4] Match data improvements for mcp4725 driver
Date: Sun, 3 Sep 2023 13:15:05 +0100 [thread overview]
Message-ID: <20230903131505.7a2bd3c3@jic23-huawei> (raw)
In-Reply-To: <20230903115548.59306-1-biju.das.jz@bp.renesas.com>
On Sun, 3 Sep 2023 12:55:44 +0100
Biju Das <biju.das.jz@bp.renesas.com> wrote:
> This patch series aims to add match data improvements for mcp4725 driver.
>
> This patch series is only compile tested.
>
> v2->v3:
> * Added struct mcp4725_chip_info with chan_spec and chip_id variable and
> used that as OF/ID table match data.
> * Added variables use_ext_ref_voltage and dac_reg_offset to struct
> mcp4725_chip_info to handle hw differences between mcp4725 and
> mcp4726.
> v1->v2:
> * Update commit description with reason for change.
>
> Biju Das (4):
> iio: dac: mcp4725: Replace variable 'id' from struct mcp4725_data
> iio: dac: mcp4725: Use i2c_get_match_data()
> iio: dac: mcp4725: Add use_ext_ref_voltage to struct mcp4725_chip_info
> iio: dac: mcp4725: Add dac_reg_offset to struct mcp4725_chip_info
>
> drivers/iio/dac/mcp4725.c | 42 ++++++++++++++++++++++++++-------------
> 1 file changed, 28 insertions(+), 14 deletions(-)
>
I've applied this, but still plenty of time for more comments as I'll only
be pushing it out as a non rebasing tree after rc1.
Thanks,
Jonathan
prev parent reply other threads:[~2023-09-03 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 11:55 [PATCH v3 0/4] Match data improvements for mcp4725 driver Biju Das
2023-09-03 11:55 ` [PATCH v3 1/4] iio: dac: mcp4725: Replace variable 'id' from struct mcp4725_data Biju Das
2023-09-03 11:55 ` [PATCH v3 2/4] iio: dac: mcp4725: Use i2c_get_match_data() Biju Das
2023-09-03 11:55 ` [PATCH v3 3/4] iio: dac: mcp4725: Add use_ext_ref_voltage to struct mcp4725_chip_info Biju Das
2023-09-03 11:55 ` [PATCH v3 4/4] iio: dac: mcp4725: Add dac_reg_offset " Biju Das
2023-09-03 12:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230903131505.7a2bd3c3@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.