Re: [PATCH] HID: sony: Fix a potential memory leak in sony_probe()

From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: Re: [PATCH] HID: sony: Fix a potential memory leak in sony_probe()
Date: Mon, 4 Sep 2023 02:37:23 +0800	[thread overview]
Message-ID: <202309040205.4e0VqT2B-lkp@intel.com> (raw)

:::::: 
:::::: Manual check reason: "checkpatch"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <db06095c912d6bc56bed6b7e4663c7994072a2ce.1693757011.git.christophe.jaillet@wanadoo.fr>
References: <db06095c912d6bc56bed6b7e4663c7994072a2ce.1693757011.git.christophe.jaillet@wanadoo.fr>
TO: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
TO: Jiri Kosina <jikos@kernel.org>
TO: Benjamin Tissoires <benjamin.tissoires@redhat.com>
TO: Pascal Giard <pascal.giard@etsmtl.ca>
CC: linux-kernel@vger.kernel.org
CC: kernel-janitors@vger.kernel.org
CC: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC: linux-input@vger.kernel.org

Hi Christophe,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/HID-sony-Fix-a-potential-memory-leak-in-sony_probe/20230904-000514
base:   linus/master
patch link:    https://lore.kernel.org/r/db06095c912d6bc56bed6b7e4663c7994072a2ce.1693757011.git.christophe.jaillet%40wanadoo.fr
patch subject: [PATCH] HID: sony: Fix a potential memory leak in sony_probe()
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
reproduce: (https://download.01.org/0day-ci/archive/20230904/202309040205.4e0VqT2B-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202309040205.4e0VqT2B-lkp@intel.com/

# many are suggestions rather than must-fix

WARNING: usb_free_urb(NULL) is safe and this check is probably not required
#24: drivers/hid/hid-sony.c:2159:
+	if (sc->ghl_urb)
+		usb_free_urb(sc->ghl_urb);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki