All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Roith <johannes@gnu-linux.rocks>
To: sergeantsagara@protonmail.com
Cc: ak@it-klinger.de, andi.shyti@kernel.org,
	benjamin.tissoires@redhat.com, christophe.jaillet@wanadoo.fr,
	jikos@kernel.org, johannes@gnu-linux.rocks,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	rdunlap@infradead.org
Subject: Re: [PATCH v5] hid-mcp2200: added driver for GPIOs of MCP2200
Date: Thu,  7 Sep 2023 18:41:21 +0200	[thread overview]
Message-ID: <20230907164121.21092-1-johannes@gnu-linux.rocks> (raw)
In-Reply-To: <87ledpvhgm.fsf@protonmail.com>

Hi Rahul,

thank you for the explanation, now I got it.

I have added hid_hw_stop and hid_hw_close to my remove function and removed the
devm_add_action_or_reset. The driver still worked well.

So, if it is okay for you, I would go this way and generate a new patch.


Best regards,
Johannes




  reply	other threads:[~2023-09-07 17:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01 19:09 [PATCH v5] hid-mcp2200: added driver for GPIOs of MCP2200 Rahul Rameshbabu
2023-09-07 16:41 ` Johannes Roith [this message]
2023-09-08  1:34   ` Rahul Rameshbabu
2023-09-18 15:14 ` [PATCH v6] HID: mcp2200: " Johannes Roith
  -- strict thread matches above, loose matches on Subject: below --
2023-08-18 10:48 [PATCH v5] hid-mcp2200: " johannes
2023-08-19 16:42 ` Rahul Rameshbabu
2023-08-31 18:53   ` Johannes Roith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230907164121.21092-1-johannes@gnu-linux.rocks \
    --to=johannes@gnu-linux.rocks \
    --cc=ak@it-klinger.de \
    --cc=andi.shyti@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sergeantsagara@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.