From: Christian Brauner <brauner@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 0/2] fs: fixes for multigrain ctime code
Date: Fri, 8 Sep 2023 14:10:37 +0200 [thread overview]
Message-ID: <20230908-gegolten-wagen-49d5559cfdb3@brauner> (raw)
In-Reply-To: <20230907-ctime-fixes-v1-0-3b74c970d934@kernel.org>
On Thu, 07 Sep 2023 12:33:46 -0400, Jeff Layton wrote:
> The kernel test robot noted some test failures with the LTP mount03 test
> on tmpfs. From the test output, it looked like the atime had gone
> backward.
>
> One way this could happen would be for tmpfs to get a new inode from the
> slab that had a ctime that appeared to be in the future.
> inode_update_ctime_current would just return that time and then the
> mtime and atime would be set to the same value. Then later, the atime
> gets overwritten by "now" which is still lower than the garbage ctime
> value.
>
> [...]
Picked up so we can get some -next testing. Hopefully that test thing can
verify the fix.
---
Applied to the vfs.ctime branch of the vfs/vfs.git tree.
Patches in the vfs.ctime branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.ctime
[1/2] fs: initialize inode->__i_ctime to the epoch
https://git.kernel.org/vfs/vfs/c/7651a330dcbd
[2/2] fs: don't update the atime if existing atime is newer than "now"
https://git.kernel.org/vfs/vfs/c/4c950d80d98d
prev parent reply other threads:[~2023-09-08 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 16:33 [PATCH 0/2] fs: fixes for multigrain ctime code Jeff Layton
2023-09-07 16:33 ` [PATCH 1/2] fs: initialize inode->__i_ctime to the epoch Jeff Layton
2023-09-08 10:42 ` Jan Kara
2023-09-08 11:41 ` Jeff Layton
2023-09-08 12:10 ` Jan Kara
2023-09-07 16:33 ` [PATCH 2/2] fs: don't update the atime if existing atime is newer than "now" Jeff Layton
2023-09-08 12:11 ` Jan Kara
2023-09-08 12:10 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908-gegolten-wagen-49d5559cfdb3@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oliver.sang@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.