From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI
Date: Fri, 15 Sep 2023 00:00:24 +0800 [thread overview]
Message-ID: <202309142309.BK8T9rG6-lkp@intel.com> (raw)
::::::
:::::: Manual check reason: "checkpatch"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230914152620.2743033-3-surenb@google.com>
References: <20230914152620.2743033-3-surenb@google.com>
TO: Suren Baghdasaryan <surenb@google.com>
Hi Suren,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Suren-Baghdasaryan/userfaultfd-UFFDIO_REMAP-rmap-preparation/20230914-232739
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230914152620.2743033-3-surenb%40google.com
patch subject: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI
:::::: branch date: 27 minutes ago
:::::: commit date: 27 minutes ago
reproduce: (https://download.01.org/0day-ci/archive/20230914/202309142309.BK8T9rG6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202309142309.BK8T9rG6-lkp@intel.com/
# many are suggestions rather than must-fix
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#66: fs/userfaultfd.c:2065:
+ BUG_ON(!ret);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#225: mm/huge_memory.c:1991:
+ BUG_ON(!pmd_trans_huge(src_pmdval));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#226: mm/huge_memory.c:1992:
+ BUG_ON(!pmd_none(dst_pmdval));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#227: mm/huge_memory.c:1993:
+ BUG_ON(!spin_is_locked(src_ptl));
WARNING: Where possible, use lockdep_assert_held instead of assertions based on spin_is_locked
#227: mm/huge_memory.c:1993:
+ BUG_ON(!spin_is_locked(src_ptl));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#230: mm/huge_memory.c:1996:
+ BUG_ON(src_addr & ~HPAGE_PMD_MASK);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#231: mm/huge_memory.c:1997:
+ BUG_ON(dst_addr & ~HPAGE_PMD_MASK);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#234: mm/huge_memory.c:2000:
+ BUG_ON(!PageHead(src_page));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#235: mm/huge_memory.c:2001:
+ BUG_ON(!PageAnon(src_page));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#279: mm/huge_memory.c:2045:
+ BUG_ON(!PageHead(src_page));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#280: mm/huge_memory.c:2046:
+ BUG_ON(!PageAnon(src_page));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#290: mm/huge_memory.c:2056:
+ BUG_ON(1);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#423: mm/userfaultfd.c:929:
+ BUG_ON(pmd_none(*dst_pmd));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#424: mm/userfaultfd.c:930:
+ BUG_ON(pmd_none(*src_pmd));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#425: mm/userfaultfd.c:931:
+ BUG_ON(pmd_trans_huge(*dst_pmd));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#426: mm/userfaultfd.c:932:
+ BUG_ON(pmd_trans_huge(*src_pmd));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#519: mm/userfaultfd.c:1025:
+ BUG_ON(!folio_test_anon(src_folio));
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#531: mm/userfaultfd.c:1037:
+ BUG_ON(1);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#603: mm/userfaultfd.c:1109:
+ BUG_ON(1);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#717: mm/userfaultfd.c:1223:
+ BUG_ON(src_start & ~PAGE_MASK);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#718: mm/userfaultfd.c:1224:
+ BUG_ON(dst_start & ~PAGE_MASK);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#719: mm/userfaultfd.c:1225:
+ BUG_ON(len & ~PAGE_MASK);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#722: mm/userfaultfd.c:1228:
+ BUG_ON(src_start + len <= src_start);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#723: mm/userfaultfd.c:1229:
+ BUG_ON(dst_start + len <= dst_start);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#800: mm/userfaultfd.c:1306:
+ BUG_ON(dst_addr >= dst_start + len);
WARNING: Prefer 'fallthrough;' over fallthrough comment
#846: mm/userfaultfd.c:1352:
+ /* Fall through */
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#920: mm/userfaultfd.c:1426:
+ BUG_ON(moved < 0);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#921: mm/userfaultfd.c:1427:
+ BUG_ON(err > 0);
WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#922: mm/userfaultfd.c:1428:
+ BUG_ON(!moved && !err);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-09-14 16:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 16:00 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-14 15:26 [PATCH 0/3] userfaultfd remap option Suren Baghdasaryan
2023-09-14 15:26 ` [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI Suren Baghdasaryan
2023-09-14 18:11 ` Matthew Wilcox
2023-09-14 18:43 ` David Hildenbrand
2023-09-14 18:45 ` David Hildenbrand
2023-09-21 18:04 ` Suren Baghdasaryan
2023-09-21 18:17 ` David Hildenbrand
2023-09-22 1:57 ` Suren Baghdasaryan
2023-09-14 18:47 ` David Hildenbrand
2023-09-14 18:54 ` Suren Baghdasaryan
2023-09-14 19:28 ` Jann Horn
2023-09-14 20:57 ` Suren Baghdasaryan
2023-09-19 23:08 ` Suren Baghdasaryan
2023-09-19 23:40 ` Suren Baghdasaryan
2023-09-19 23:50 ` Jann Horn
2023-09-20 1:49 ` Suren Baghdasaryan
2023-09-20 16:11 ` Jann Horn
2023-09-21 16:59 ` Jann Horn
2023-09-14 21:57 ` Nadav Amit
2023-09-15 3:28 ` Suren Baghdasaryan
2023-09-15 4:03 ` Nadav Amit
2023-09-15 4:15 ` Suren Baghdasaryan
2023-09-15 23:33 ` Jann Horn
2023-09-15 23:39 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309142309.BK8T9rG6-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.