All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-mm@kvack.org, Suren Baghdasaryan <surenb@google.com>
Subject: [PATCH 5/6] mm: Handle read faults under the VMA lock
Date: Wed, 27 Sep 2023 06:25:03 +0100	[thread overview]
Message-ID: <20230927052505.2855872-6-willy@infradead.org> (raw)
In-Reply-To: <20230927052505.2855872-1-willy@infradead.org>

Most file-backed faults are already handled through ->map_pages(),
but if we need to do I/O we'll come this way.  Since filemap_fault()
is now safe to be called under the VMA lock, we can handle these faults
under the VMA lock now.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/memory.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 02231a9394ed..5f92126dc527 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -4617,10 +4617,9 @@ static vm_fault_t do_read_fault(struct vm_fault *vmf)
 			return ret;
 	}
 
-	if (vmf->flags & FAULT_FLAG_VMA_LOCK) {
-		vma_end_read(vmf->vma);
-		return VM_FAULT_RETRY;
-	}
+	ret = vmf_maybe_unlock_vma(vmf);
+	if (ret)
+		return ret;
 
 	ret = __do_fault(vmf);
 	if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))
-- 
2.40.1



  parent reply	other threads:[~2023-09-27  5:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27  5:24 [PATCH 0/6] Handle more faults under the VMA lock Matthew Wilcox (Oracle)
2023-09-27  5:24 ` [PATCH 1/6] mm: Make lock_folio_maybe_drop_mmap() VMA lock aware Matthew Wilcox (Oracle)
2023-09-27  5:25 ` [PATCH 2/6] mm: Call wp_page_copy() under the VMA lock Matthew Wilcox (Oracle)
2023-09-27 22:38   ` Suren Baghdasaryan
2023-09-28  5:18     ` Matthew Wilcox
2023-09-28 14:57       ` Suren Baghdasaryan
2023-09-27  5:25 ` [PATCH 3/6] mm: Handle shared faults " Matthew Wilcox (Oracle)
2023-09-28  0:46   ` Suren Baghdasaryan
2023-09-28  1:02     ` Suren Baghdasaryan
2023-09-28  5:33       ` Matthew Wilcox
2023-09-28 15:02         ` Suren Baghdasaryan
2023-09-27  5:25 ` [PATCH 4/6] mm: Handle COW " Matthew Wilcox (Oracle)
2023-09-28  0:53   ` Suren Baghdasaryan
2023-09-27  5:25 ` Matthew Wilcox (Oracle) [this message]
2023-09-27  5:25 ` [PATCH 6/6] mm: Handle write faults to RO pages " Matthew Wilcox (Oracle)
2023-09-27 22:18 ` [PATCH 0/6] Handle more faults " Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927052505.2855872-6-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.