From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sean Young <sean@mess.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH 2/2] media: pwm-ir-tx: trigger edges from hrtimer interrupt context
Date: Mon, 2 Oct 2023 10:59:02 +0200 [thread overview]
Message-ID: <20231002085902.63b6cpql5tgwdhbw@pengutronix.de> (raw)
In-Reply-To: <ZRp9RE2jOZdL0+1/@gofer.mess.org>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
Hello Sean,
On Mon, Oct 02, 2023 at 09:20:20AM +0100, Sean Young wrote:
> Having said that, the extra call to pwm_apply_state() may have benefits,
> see this comment in the pwm-sifive driver:
>
> * - When changing both duty cycle and period, we cannot prevent in
> * software that the output might produce a period with mixed
> * settings (new period length and old duty cycle).
You don't gain anything here I think. Disabling a PWM might also result
in a constant active level. If you want to prevent this, your best bet
is to never disable the PWM.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-10-02 8:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 10:40 [PATCH 0/2] Improve pwm-ir-tx precision Sean Young
2023-10-01 10:40 ` [PATCH 1/2] pwm: make it possible to apply pwm changes in atomic context Sean Young
2023-10-01 10:40 ` Sean Young
2023-10-01 10:40 ` Sean Young
2023-10-01 14:43 ` kernel test robot
2023-10-01 14:43 ` kernel test robot
2023-10-01 14:43 ` kernel test robot
2023-10-01 16:07 ` kernel test robot
2023-10-01 16:07 ` kernel test robot
2023-10-01 16:07 ` kernel test robot
2023-10-01 17:21 ` Sean Young
2023-10-01 17:21 ` Sean Young
2023-10-01 17:21 ` Sean Young
2023-10-04 9:59 ` Uwe Kleine-König
2023-10-04 9:59 ` Uwe Kleine-König
2023-10-04 9:59 ` Uwe Kleine-König
2023-10-05 8:30 ` Sean Young
2023-10-05 8:30 ` Sean Young
2023-10-05 8:30 ` Sean Young
2023-10-05 9:17 ` Uwe Kleine-König
2023-10-05 9:17 ` Uwe Kleine-König
2023-10-05 9:17 ` Uwe Kleine-König
2023-10-06 10:27 ` Thierry Reding
2023-10-06 10:27 ` Thierry Reding
2023-10-06 10:27 ` Thierry Reding
2023-10-06 14:44 ` Uwe Kleine-König
2023-10-06 14:44 ` Uwe Kleine-König
2023-10-06 14:44 ` Uwe Kleine-König
2023-10-06 10:29 ` Thierry Reding
2023-10-06 10:29 ` Thierry Reding
2023-10-06 10:29 ` Thierry Reding
2023-10-01 10:40 ` [PATCH 2/2] media: pwm-ir-tx: trigger edges from hrtimer interrupt context Sean Young
2023-10-02 5:49 ` Ivaylo Dimitrov
2023-10-02 8:20 ` Sean Young
2023-10-02 8:59 ` Uwe Kleine-König [this message]
2023-10-02 9:52 ` Ivaylo Dimitrov
2023-10-04 7:43 ` Sean Young
2023-10-04 9:35 ` Uwe Kleine-König
2023-10-02 6:16 ` Ivaylo Dimitrov
2023-10-04 8:00 ` Sean Young
2023-10-04 12:54 ` Ivaylo Dimitrov
2023-10-04 14:42 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002085902.63b6cpql5tgwdhbw@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.