From: zhujun2 <zhujun2@cmss.chinamobile.com>
To: shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
zhujun2@cmss.chinamobile.com
Subject: [PATCH] selftests/efivarfs: create-read: fix a resource leak
Date: Mon, 16 Oct 2023 19:33:35 -0700 [thread overview]
Message-ID: <20231017023335.7874-1-zhujun2@cmss.chinamobile.com> (raw)
The opened file should be closed in main(), otherwise resource
leak will occur
Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
---
tools/testing/selftests/efivarfs/create-read.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
index 9674a1939..6812104a5 100644
--- a/tools/testing/selftests/efivarfs/create-read.c
+++ b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,11 @@ int main(int argc, char **argv)
rc = read(fd, buf, sizeof(buf));
if (rc != 0) {
fprintf(stderr, "Reading a new var should return EOF\n");
+ close(fd);
return EXIT_FAILURE;
}
+ close(fd);
+
return EXIT_SUCCESS;
}
--
2.17.1
next reply other threads:[~2023-10-17 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 2:33 zhujun2 [this message]
2023-10-17 15:46 ` [PATCH] selftests/efivarfs: create-read: fix a resource leak Shuah Khan
2023-10-18 1:59 ` zhujun2
2023-10-18 19:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017023335.7874-1-zhujun2@cmss.chinamobile.com \
--to=zhujun2@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.