From: kernel test robot <lkp@intel.com>
To: Wenchao Hao <haowenchao2@huawei.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
louhongxiang@huawei.com, Wenchao Hao <haowenchao2@huawei.com>
Subject: Re: [PATCH v3 1/4] scsi: core: Add new helper to iterate all devices of host
Date: Tue, 17 Oct 2023 23:31:50 +0800 [thread overview]
Message-ID: <202310172345.jViTGPKD-lkp@intel.com> (raw)
In-Reply-To: <20231016020314.1269636-2-haowenchao2@huawei.com>
Hi Wenchao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wenchao-Hao/scsi-core-Add-new-helper-to-iterate-all-devices-of-host/20231017-140049
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20231016020314.1269636-2-haowenchao2%40huawei.com
patch subject: [PATCH v3 1/4] scsi: core: Add new helper to iterate all devices of host
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310172345.jViTGPKD-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310172345.jViTGPKD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310172345.jViTGPKD-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/scsi/scsi.c:767: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* helper for shost_for_each_device, see that for documentation
vim +767 drivers/scsi/scsi.c
765
766 /**
> 767 * helper for shost_for_each_device, see that for documentation
768 * @skip_deleted: if true, sdev in progress of removing would be skipped
769 */
770 struct scsi_device *__scsi_iterate_devices(struct Scsi_Host *shost,
771 struct scsi_device *prev,
772 bool skip_deleted)
773 {
774 struct list_head *list = (prev ? &prev->siblings : &shost->__devices);
775 struct scsi_device *next = NULL;
776 unsigned long flags;
777
778 spin_lock_irqsave(shost->host_lock, flags);
779 while (list->next != &shost->__devices) {
780 next = list_entry(list->next, struct scsi_device, siblings);
781 /* skip devices that we can't get a reference to */
782 if (!__scsi_device_get(next, skip_deleted))
783 break;
784 next = NULL;
785 list = list->next;
786 }
787 spin_unlock_irqrestore(shost->host_lock, flags);
788
789 if (prev)
790 scsi_device_put(prev);
791 return next;
792 }
793 EXPORT_SYMBOL(__scsi_iterate_devices);
794
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-17 15:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 2:03 [PATCH v3 0/4] SCSI: Fix issues between removing device and error handle Wenchao Hao
2023-10-16 2:03 ` [PATCH v3 1/4] scsi: core: Add new helper to iterate all devices of host Wenchao Hao
2023-10-17 15:31 ` kernel test robot [this message]
2023-10-16 2:03 ` [PATCH v3 2/4] scsi: scsi_error: Fix wrong statistic when print error info Wenchao Hao
2023-10-16 2:03 ` [PATCH v3 3/4] scsi: scsi_error: Fix device reset is not triggered Wenchao Hao
2023-10-16 2:03 ` [PATCH v3 4/4] scsi: scsi_core: Fix IO hang when device removing Wenchao Hao
2023-11-14 21:23 ` Mike Christie
2023-11-14 21:47 ` Mike Christie
2023-11-15 16:24 ` Wenchao Hao
2024-03-07 14:36 ` Wenchao Hao
2023-10-17 17:00 ` [PATCH v3 0/4] SCSI: Fix issues between removing device and error handle Wenchao Hao
2023-10-17 21:41 ` Bart Van Assche
2023-10-18 1:37 ` Wenchao Hao
2023-10-18 13:51 ` Bart Van Assche
2023-10-18 14:40 ` Wenchao Hao
2023-10-18 18:03 ` Bart Van Assche
2023-11-13 16:00 ` Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310172345.jViTGPKD-lkp@intel.com \
--to=lkp@intel.com \
--cc=haowenchao2@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.