Re: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down

From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: Re: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down
Date: Sun, 22 Oct 2023 18:34:35 +0800	[thread overview]
Message-ID: <202310221806.gdrl0tU9-lkp@intel.com> (raw)

:::::: 
:::::: Manual check reason: "git am base is a link in commit message"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20231016040132.23824-1-kai.heng.feng@canonical.com>
References: <20231016040132.23824-1-kai.heng.feng@canonical.com>
TO: "Kai-Heng Feng" <kai.heng.feng@canonical.com>
TO: bhelgaas@google.com
CC: linux-pm@vger.kernel.org
CC: linux-mmc@vger.kernel.org
CC: "Kai-Heng Feng" <kai.heng.feng@canonical.com>
CC: Ricky Wu <ricky_wu@realtek.com>
CC: Kees Cook <keescook@chromium.org>
CC: Tony Luck <tony.luck@intel.com>
CC: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
CC: Lukas Wunner <lukas@wunner.de>
CC: linux-pci@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-hardening@vger.kernel.org
CC: bpf@vger.kernel.org

Hi Kai-Heng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.6-rc6 next-20231020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kai-Heng-Feng/PCI-pciehp-Prevent-child-devices-from-doing-RPM-on-PCIe-Link-Down/20231017-142208
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20231016040132.23824-1-kai.heng.feng%40canonical.com
patch subject: [PATCH] PCI: pciehp: Prevent child devices from doing RPM on PCIe Link Down
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: i386-randconfig-005-20231022 (https://download.01.org/0day-ci/archive/20231022/202310221806.gdrl0tU9-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231022/202310221806.gdrl0tU9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202310221806.gdrl0tU9-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/hotplug/pciehp_pci.c:25:5: warning: no previous declaration for 'pci_dev_disconnect' [-Wmissing-declarations]
    int pci_dev_disconnect(struct pci_dev *pdev, void *unused)
        ^~~~~~~~~~~~~~~~~~

vim +/pci_dev_disconnect +25 drivers/pci/hotplug/pciehp_pci.c

^1da177e4c3f415 Linus Torvalds 2005-04-16  24  
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16 @25  int pci_dev_disconnect(struct pci_dev *pdev, void *unused)
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  26  {
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  27  	pm_runtime_barrier(&pdev->dev);
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  28  	pci_dev_set_disconnected(pdev, NULL);
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  29  
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  30  	return 0;
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  31  }
2bd1cb5c4e67115 Kai-Heng Feng  2023-10-16  32  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki