Re: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema

From: Conor Dooley <conor@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Support Opensource <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema
Date: Mon, 23 Oct 2023 17:18:45 +0100	[thread overview]
Message-ID: <20231023-sulfate-babble-695b239f52b5@spud> (raw)
In-Reply-To: <bfd1cf9d620a8229f5a5e62e6fe9e59c153d0830.1698051619.git.geert+renesas@glider.be>

[-- Attachment #1: Type: text/plain, Size: 3543 bytes --]

On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:
> Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> Converter Device Tree binding documentation to json-schema.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  .../devicetree/bindings/regulator/da9210.txt  | 29 -----------
>  .../bindings/regulator/dlg,da9210.yaml        | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/regulator/da9210.txt
>  create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/da9210.txt b/Documentation/devicetree/bindings/regulator/da9210.txt
> deleted file mode 100644
> index 58065ca9e3b46892..0000000000000000
> --- a/Documentation/devicetree/bindings/regulator/da9210.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -* Dialog Semiconductor DA9210 Multi-phase 12A DCDC BUCK Converter
> -
> -Required properties:
> -
> -- compatible:	must be "dlg,da9210"
> -- reg:		the i2c slave address of the regulator. It should be 0x68.
> -
> -Optional properties:
> -
> -- interrupts:	a reference to the DA9210 interrupt, if available.
> -
> -Any standard regulator properties can be used to configure the single da9210
> -DCDC.
> -
> -Example:
> -
> -	da9210@68 {
> -		compatible = "dlg,da9210";
> -		reg = <0x68>;
> -
> -		interrupt-parent = <...>;
> -		interrupts = <...>;
> -
> -		regulator-min-microvolt = <300000>;
> -		regulator-max-microvolt = <1570000>;
> -		regulator-min-microamp = <1600000>;
> -		regulator-max-microamp = <4600000>;
> -		regulator-boot-on;
> -	};
> diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> new file mode 100644
> index 0000000000000000..81f23de36de4c2f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
> +
> +maintainers:
> +  - Support Opensource <support.opensource@diasemi.com>

This should really be a person... Does your work with Renesas cover you
for dialog stuff too?

Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    const: dlg,da9210
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        regulator@68 {
> +            compatible = "dlg,da9210";
> +            reg = <0x68>;
> +
> +            interrupt-parent = <&irqc0>;
> +            interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +
> +            regulator-min-microvolt = <300000>;
> +            regulator-max-microvolt = <1570000>;
> +            regulator-min-microamp = <1600000>;
> +            regulator-max-microamp = <4600000>;
> +            regulator-boot-on;
> +        };
> +    };
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]