From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-usb@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-kselftest@vger.kernel.org, kernel@collabora.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] kselftest: devices: Add board file for google,spherion
Date: Wed, 25 Oct 2023 12:32:15 +0200 [thread overview]
Message-ID: <2023102546-filled-onboard-3dfb@gregkh> (raw)
In-Reply-To: <20231024211818.365844-3-nfraprado@collabora.com>
On Tue, Oct 24, 2023 at 05:18:00PM -0400, Nícolas F. R. A. Prado wrote:
> Add the list of devices expected to be probed from the USB and PCI
> busses on the google,spherion machine. The USB host controller at
> 11200000 is shared between two busses, for USB2 and USB3, so an
> additional match is used to select the USB2 bus.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>
> tools/testing/selftests/devices/boards/google,spherion | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 tools/testing/selftests/devices/boards/google,spherion
>
> diff --git a/tools/testing/selftests/devices/boards/google,spherion b/tools/testing/selftests/devices/boards/google,spherion
> new file mode 100644
> index 000000000000..ba86ffcfe43c
> --- /dev/null
> +++ b/tools/testing/selftests/devices/boards/google,spherion
> @@ -0,0 +1,3 @@
> +usb camera 11200000,PRODUCT=.*/2/.* 1.4.1 1 0,1
> +usb bluetooth 11200000,PRODUCT=.*/2/.* 1.4.2 1 0,1
> +pci wifi 11230000 0.0/0.0
USB busses (and PCI ids) are not determinisitic and can, and will,
change values randomly. So while it is nice to test "did the devices
show up properly", you can not do that based on bus ids at all, sorry.
Unless I'm reading these values wrong? What are the fields
representing? Perhaps a comment at the top to describe them so that we
know how to parse them?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-25 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 21:17 [RFC PATCH 0/2] Add test to verify probe of devices from discoverable busses on DT platforms Nícolas F. R. A. Prado
2023-10-24 21:17 ` [RFC PATCH 1/2] kselftest: Add test to verify probe of devices from discoverable busses Nícolas F. R. A. Prado
2023-10-24 21:18 ` [RFC PATCH 2/2] kselftest: devices: Add board file for google,spherion Nícolas F. R. A. Prado
2023-10-25 10:32 ` Greg Kroah-Hartman [this message]
2023-10-25 12:32 ` Nícolas F. R. A. Prado
2023-10-27 10:48 ` Greg Kroah-Hartman
2023-10-27 20:31 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102546-filled-onboard-3dfb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.