From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Christian Brauner <brauner@kernel.org>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] fanotify support for btrfs sub-volumes
Date: Thu, 26 Oct 2023 18:09:41 +0200 [thread overview]
Message-ID: <20231026160941.mja25aiww6mccnzi@quack3> (raw)
In-Reply-To: <20231026155224.129326-1-amir73il@gmail.com>
On Thu 26-10-23 18:52:21, Amir Goldstein wrote:
> As agreed on the review of v1 [1], we do not need any vfs changes
> to support fanotify on btrfs sub-volumes and we can enable setting
> marks on btrfs sub-volumes simply by caching the fsid in the mark
> object instead of the connector.
>
> This is the would be man page update to clarify the meaning of fsid
> as it is reflected in this patch set:
>
> fsid
>
> This is a unique identifier of the filesystem containing the object
> associated with the event. It is a structure of type __kernel_fsid_t
> and contains the same value reported in f_fsid when calling
> statfs(2) with the same pathname argument that was used for
> fanotify_mark(2). Note that some filesystems (e.g., btrfs(5)) report
> non-uniform values of f_fsid on different objects of the same filesystem.
> In these cases, if fanotify_mark(2) is called several times with different
> pathname values, the fsid value reported in events will match f_fsid
> associated with at least one of those pathname values.
Thanks! The patchset looks good to me but I don't want to queue it now so
shortly before the merge window opens. So I'll queue it into my tree once
I'll push out changes for the merge window.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-10-26 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:52 [PATCH v2 0/3] fanotify support for btrfs sub-volumes Amir Goldstein
2023-10-26 15:52 ` [PATCH v2 1/3] fanotify: store fsid in mark instead of in connector Amir Goldstein
2023-10-26 15:52 ` [PATCH v2 2/3] fanotify: report the most specific fsid for btrfs Amir Goldstein
2023-10-26 15:52 ` [PATCH v2 3/3] fanotify: support setting marks in btrfs sub-volumes Amir Goldstein
2023-10-26 16:09 ` Jan Kara [this message]
2023-10-27 5:46 ` [PATCH v2 0/3] fanotify support for " Christoph Hellwig
2023-10-27 6:03 ` Amir Goldstein
2023-10-27 6:08 ` Christoph Hellwig
2023-10-27 6:33 ` Amir Goldstein
2023-10-27 7:30 ` Christoph Hellwig
2023-10-27 15:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026160941.mja25aiww6mccnzi@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.