All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org
Subject: Apply a1e2c031ec39 and e32683c6f7d2 to 5.15 and earlier
Date: Fri, 27 Oct 2023 09:01:44 -0700	[thread overview]
Message-ID: <20231027160144.GA232578@dev-arch.thelio-3990X> (raw)

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

Hi Greg and Sasha,

Please consider applying the following mbox files to their respective
stable trees, which contains commit a1e2c031ec39 ("x86/mm: Simplify
RESERVE_BRK()") and commit e32683c6f7d2 ("x86/mm: Fix RESERVE_BRK() for
older binutils"). This resolves a link failure noticed in the Android
trees due to a new diagnostic in ld.lld:

https://github.com/llvm/llvm-project/commit/1981b1b6b92f7579a30c9ed32dbdf3bc749c1b40

  ld.lld: error: relocation refers to a symbol in a discarded section: __brk_reservation_fn_dmi_alloc__
  >>> defined in vmlinux.o
  >>> referenced by ld-temp.o
  >>>               vmlinux.o:(exit_amd_microcode.cfi_jt)

  ld.lld: error: relocation refers to a symbol in a discarded section: __brk_reservation_fn_early_pgt_alloc__
  >>> defined in vmlinux.o
  >>> referenced by ld-temp.o
  >>>               vmlinux.o:(exit_amd_microcode.cfi_jt)

While I think this may be related to Android's downstream use of LTO and
CFI, I see no reason that this could not happen without LTO due to
RESERVE_BRK() prior to those upstream commits residing in the
.discard.text section.

I confirmed they resolve the Android build problem and I did an
ARCH=x86_64 defconfig build and boot test in QEMU and an allmodconfig
build with GCC, which had no regressions.

Cheers,
Nathan

[-- Attachment #2: 4.14.mbox --]
[-- Type: application/mbox, Size: 8593 bytes --]

[-- Attachment #3: 4.19.mbox --]
[-- Type: application/mbox, Size: 8593 bytes --]

[-- Attachment #4: 5.4.mbox --]
[-- Type: application/mbox, Size: 8618 bytes --]

[-- Attachment #5: 5.10.mbox --]
[-- Type: application/mbox, Size: 9117 bytes --]

[-- Attachment #6: 5.15.mbox --]
[-- Type: application/mbox, Size: 8940 bytes --]

             reply	other threads:[~2023-10-27 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 16:01 Nathan Chancellor [this message]
2023-10-27 17:47 ` Apply a1e2c031ec39 and e32683c6f7d2 to 5.15 and earlier kernel test robot
2023-10-31 12:54 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231027160144.GA232578@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.