From: Greg KH <gregkh@linuxfoundation.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: "Sasha Levin" <sashal@kernel.org>,
stable@vger.kernel.org, "Faiz Abbas" <faiz_abbas@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@ew.tq-group.com
Subject: Re: [PATCH 5.4] Revert "ARM: dts: Move am33xx and am43xx mmc nodes to sdhci-omap driver"
Date: Mon, 6 Nov 2023 12:28:28 +0100 [thread overview]
Message-ID: <2023110613-fringe-ended-5390@gregkh> (raw)
In-Reply-To: <20231106095048.8396-1-matthias.schiffer@ew.tq-group.com>
On Mon, Nov 06, 2023 at 10:50:48AM +0100, Matthias Schiffer wrote:
> This reverts commit d0c69c722ff16ce2481a5e0932c6d5b172109f21.
>
> The reverted commit completely breaks MMC on the AM33xx/AM437x for
> multiple reasons:
>
> - The changed compatible strings ti,am335-sdhci and ti,am437-sdhci
> aren't supported on Linux 5.4 at all, so no driver is found
> - Even when additionally backporting the support for these compatible
> strings in the sdhci-omap driver, I could not the the MMC interfaces
> to work on our TQMa335x SoM - the interface would time out during card
> initialization for both an eMMC and an SD card.
>
> I did not investigate the cause of the timeouts further, and instead
> just reverted the commit - switching to a different MMC driver in a stable
> kernel seems like a rather risky change unless it's thoroughly tested,
> which has obviously not happened in this case.
>
> The reverted commit is also given as a Stable-dep-of commit 2eb502f496f7
> ("ARM: dts: am33xx: Fix MMCHS0 dma properties"), however the conflict
> resulting when only the one commit is reverted is trivial to resolve,
> which leads to working MMC controllers again.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>
> I have not checked if other stable kernels exhibit the same breakage; it
> might be a good idea to revert the change for all stable branches unless
> it is proven that the sdhci-omap driver actually works.
This was only backported to 5.4.y, thanks for catching this, now queued
up.
greg k-h
prev parent reply other threads:[~2023-11-06 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 9:50 [PATCH 5.4] Revert "ARM: dts: Move am33xx and am43xx mmc nodes to sdhci-omap driver" Matthias Schiffer
2023-11-06 11:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023110613-fringe-ended-5390@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=mark.rutland@arm.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=robh+dt@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.