All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stewart Hildebrand <stewart.hildebrand@amd.com>
To: <xen-devel@lists.xenproject.org>
Cc: Rahul Singh <rahul.singh@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@amd.com>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	Stewart Hildebrand <stewart.hildebrand@amd.com>
Subject: [PATCH v6 7/9] xen/arm: Fix mapping for PCI bridge mmio region
Date: Thu, 9 Nov 2023 13:27:10 -0500	[thread overview]
Message-ID: <20231109182716.367119-8-stewart.hildebrand@amd.com> (raw)
In-Reply-To: <20231109182716.367119-1-stewart.hildebrand@amd.com>

From: Rahul Singh <rahul.singh@arm.com>

Current code skip the mapping for PCI bridge MMIO region to dom0 when
pci_passthrough_enabled flag is set. Mapping should be skip when
has_vpci(d) is enabled for the domain, as we need to skip the mapping
only when VPCI handler are registered for ECAM.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@amd.com>
---
This patch was originally picked up from [1]

v5->v6:
* drop unrelated change in xen/arch/arm/domain_build.c:handle_linux_pci_domain()

v4->v5:
* new patch

changes since picking up from [1]:
* rebase on top of "dynamic node programming using overlay dtbo" series
* replace !is_pci_passthrough_enabled() check with !IS_ENABLED(CONFIG_HAS_PCI)
  instead of removing

[1] https://lists.xenproject.org/archives/html/xen-devel/2023-07/msg00483.html
---
 xen/arch/arm/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c
index 1f631d327441..4d69c298858d 100644
--- a/xen/arch/arm/device.c
+++ b/xen/arch/arm/device.c
@@ -330,7 +330,7 @@ int handle_device(struct domain *d, struct dt_device_node *dev, p2m_type_t p2mt,
         .d = d,
         .p2mt = p2mt,
         .skip_mapping = !own_device ||
-                        (is_pci_passthrough_enabled() &&
+                        (has_vpci(d) &&
                         (device_get_class(dev) == DEVICE_PCI_HOSTBRIDGE)),
         .iomem_ranges = iomem_ranges,
         .irq_ranges = irq_ranges
-- 
2.42.0



  parent reply	other threads:[~2023-11-09 18:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 18:27 [PATCH v6 0/9] SMMU handling for PCIe Passthrough on ARM Stewart Hildebrand
2023-11-09 18:27 ` [PATCH v6 1/9] xen/arm: don't pass iommu properties to hwdom for iommu-map Stewart Hildebrand
2023-12-13 10:46   ` Julien Grall
2023-11-09 18:27 ` [PATCH v6 2/9] iommu/arm: Add iommu_dt_xlate() Stewart Hildebrand
2023-11-10  8:39   ` Jan Beulich
2023-11-09 18:27 ` [PATCH v6 3/9] iommu/arm: Introduce iommu_add_dt_pci_sideband_ids API Stewart Hildebrand
2023-11-10  8:49   ` Jan Beulich
2023-12-15 19:28   ` Julien Grall
2023-11-09 18:27 ` [PATCH v6 4/9] iommu/arm: iommu_add_dt_pci_sideband_ids phantom handling Stewart Hildebrand
2023-11-09 18:27 ` [PATCH v6 5/9] xen/arm: smmuv2: Add PCI devices support for SMMUv2 Stewart Hildebrand
2023-12-19 19:25   ` Julien Grall
2023-11-09 18:27 ` [PATCH v6 6/9] xen/arm: smmuv3: Add PCI devices support for SMMUv3 Stewart Hildebrand
2023-12-19 19:27   ` Julien Grall
2023-11-09 18:27 ` Stewart Hildebrand [this message]
2023-12-19 19:31   ` [PATCH v6 7/9] xen/arm: Fix mapping for PCI bridge mmio region Julien Grall
2023-11-09 18:27 ` [PATCH v6 8/9] xen/arm: enable dom0 to use PCI devices with pci-passthrough=no Stewart Hildebrand
2023-11-10  8:53   ` Jan Beulich
2023-12-19 19:36   ` Julien Grall
2023-11-09 18:27 ` [PATCH v6 9/9] xen/arm: Map ITS doorbell register to IOMMU page tables Stewart Hildebrand
2023-12-19 19:47   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109182716.367119-8-stewart.hildebrand@amd.com \
    --to=stewart.hildebrand@amd.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=bertrand.marquis@arm.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=rahul.singh@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.