Re: [PATCH] media: vsp1: Remove unbalanced .s_stream(0) calls

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-media@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] media: vsp1: Remove unbalanced .s_stream(0) calls
Date: Mon, 13 Nov 2023 16:19:30 +0200	[thread overview]
Message-ID: <20231113141930.GB12711@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdV-fMaT-H4m9twdb+Ow7tCM4GZNDD4b1vn7e2B8VQmS8g@mail.gmail.com>

Hi Geert,

On Mon, Nov 13, 2023 at 03:05:07PM +0100, Geert Uytterhoeven wrote:
> On Tue, Oct 24, 2023 at 4:56 PM Geert Uytterhoeven wrote:
> > On Tue, Oct 24, 2023 at 4:25 PM Laurent Pinchart wrote:
> > > The VSP1 driver uses the subdev .s_stream() operation to stop WPF
> > > instances, without a corresponding call to start them. The V4L2 subdev
> > > core started warning about unbalanced .s_stream() calls in commit
> > > 009905ec5043 ("media: v4l2-subdev: Document and enforce .s_stream()
> > > requirements"), causing a regression with this driver.
> > >
> > > Fix the problem by replacing the .s_stream() operation with an explicit
> > > function call for WPF instances. This allows sharing an additional data
> > > structure between RPF and WPF instances.
> > >
> > > Fixes: 009905ec5043 ("media: v4l2-subdev: Document and enforce .s_stream() requirements")
> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Closes: https://lore.kernel.org/linux-media/2221395-6a9b-9527-d697-e76aebc6af@linux-m68k.org/
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > Thanks for your patch!
> >
> > The warning splat is gone, so
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> FTR, the warning splat is now in v6.7-rc1, but the fix is not
> (not even in linux-next).

I know. I've sent a pull request for it yesterday, it should get merged
in time for v6.7.

-- 
Regards,

Laurent Pinchart