From: kernel test robot <lkp@intel.com>
To: Lukas Funke <lukas.funke-oss@weidmueller.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Lukas Funke <Lukas.Funke@weidmueller.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: usbc-tusb320: Set interrupt polarity based on device-tree
Date: Thu, 23 Nov 2023 09:54:44 +0800 [thread overview]
Message-ID: <202311230606.jY9zcxcB-lkp@intel.com> (raw)
In-Reply-To: <20231121124844.872238-1-lukas.funke-oss@weidmueller.com>
Hi Lukas,
kernel test robot noticed the following build errors:
[auto build test ERROR on chanwoo-extcon/extcon-next]
[also build test ERROR on linus/master v6.7-rc2 next-20231122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lukas-Funke/extcon-usbc-tusb320-Set-interrupt-polarity-based-on-device-tree/20231121-205141
base: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git extcon-next
patch link: https://lore.kernel.org/r/20231121124844.872238-1-lukas.funke-oss%40weidmueller.com
patch subject: [PATCH] extcon: usbc-tusb320: Set interrupt polarity based on device-tree
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231123/202311230606.jY9zcxcB-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231123/202311230606.jY9zcxcB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311230606.jY9zcxcB-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/extcon/extcon-usbc-tusb320.c:573:10: error: call to undeclared function 'irq_get_irq_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
irq_d = irq_get_irq_data(client->irq);
^
drivers/extcon/extcon-usbc-tusb320.c:573:10: note: did you mean 'irq_set_irq_wake'?
include/linux/interrupt.h:482:12: note: 'irq_set_irq_wake' declared here
extern int irq_set_irq_wake(unsigned int irq, unsigned int on);
^
>> drivers/extcon/extcon-usbc-tusb320.c:573:8: error: incompatible integer to pointer conversion assigning to 'struct irq_data *' from 'int' [-Wint-conversion]
irq_d = irq_get_irq_data(client->irq);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/extcon/extcon-usbc-tusb320.c:579:12: error: call to undeclared function 'irqd_get_trigger_type'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
irq_pol = irqd_get_trigger_type(irq_d);
^
3 errors generated.
vim +/irq_get_irq_data +573 drivers/extcon/extcon-usbc-tusb320.c
511
512 static int tusb320_probe(struct i2c_client *client)
513 {
514 struct tusb320_priv *priv;
515 const void *match_data;
516 unsigned int revision;
517 int ret;
518 int irq_pol;
519 struct irq_data *irq_d;
520
521 priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
522 if (!priv)
523 return -ENOMEM;
524
525 priv->dev = &client->dev;
526 i2c_set_clientdata(client, priv);
527
528 priv->regmap = devm_regmap_init_i2c(client, &tusb320_regmap_config);
529 if (IS_ERR(priv->regmap))
530 return PTR_ERR(priv->regmap);
531
532 ret = tusb320_check_signature(priv);
533 if (ret)
534 return ret;
535
536 match_data = device_get_match_data(&client->dev);
537 if (!match_data)
538 return -EINVAL;
539
540 priv->ops = (struct tusb320_ops*)match_data;
541
542 if (priv->ops->get_revision) {
543 ret = priv->ops->get_revision(priv, &revision);
544 if (ret)
545 dev_warn(priv->dev,
546 "failed to read revision register: %d\n", ret);
547 else
548 dev_info(priv->dev, "chip revision %d\n", revision);
549 }
550
551 ret = tusb320_extcon_probe(priv);
552 if (ret)
553 return ret;
554
555 ret = tusb320_typec_probe(client, priv);
556 if (ret)
557 return ret;
558
559 /* update initial state */
560 tusb320_state_update_handler(priv, true);
561
562 /* Reset chip to its default state */
563 ret = tusb320_reset(priv);
564 if (ret)
565 dev_warn(priv->dev, "failed to reset chip: %d\n", ret);
566 else
567 /*
568 * State and polarity might change after a reset, so update
569 * them again and make sure the interrupt status bit is cleared.
570 */
571 tusb320_state_update_handler(priv, true);
572
> 573 irq_d = irq_get_irq_data(client->irq);
574 if (!irq_d) {
575 dev_err(&client->dev, "Invalid IRQ: %d\n", client->irq);
576 return -ENODEV;
577 }
578
> 579 irq_pol = irqd_get_trigger_type(irq_d);
580
581 ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
582 tusb320_irq_handler,
583 IRQF_ONESHOT | irq_pol,
584 client->name, priv);
585 if (ret)
586 tusb320_typec_remove(priv);
587
588 return ret;
589 }
590
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-11-23 1:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:48 [PATCH] extcon: usbc-tusb320: Set interrupt polarity based on device-tree Lukas Funke
2023-11-22 0:54 ` kernel test robot
2023-11-22 7:19 ` kernel test robot
2023-11-22 8:07 ` [PATCH v2] " Lukas Funke
2023-12-04 12:09 ` Chanwoo Choi
2023-12-04 12:32 ` Chanwoo Choi
2023-12-04 12:49 ` Chanwoo Choi
2023-12-04 13:22 ` Lukas Funke
2023-11-23 1:54 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311230606.jY9zcxcB-lkp@intel.com \
--to=lkp@intel.com \
--cc=Lukas.Funke@weidmueller.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lukas.funke-oss@weidmueller.com \
--cc=myungjoo.ham@samsung.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.